Skip to content

FEAT: Add function to emit to list all component types - #6210

Merged
jsalant22 merged 11 commits into
mainfrom
FEAT__Add_function_to_EMIT_to_list_all_component_types
Jun 3, 2025
Merged

FEAT: Add function to emit to list all component types#6210
jsalant22 merged 11 commits into
mainfrom
FEAT__Add_function_to_EMIT_to_list_all_component_types

Conversation

@ramin4667

Copy link
Copy Markdown
Contributor

Description

This PR adds a search feature to find components for EMIT application .

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ramin4667
ramin4667 requested a review from a team as a code owner May 28, 2025 14:15
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@ramin4667
ramin4667 requested a review from jsalant22 May 28, 2025 14:15
@github-actions github-actions Bot added the enhancement New features or code improvements label May 28, 2025
@codecov

codecov Bot commented May 28, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (9c68b0a) to head (e67bea8).
Report is 5 commits behind head on main.

❌ Your patch status has failed because the patch coverage (77.77%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6210      +/-   ##
==========================================
+ Coverage   84.06%   85.21%   +1.14%     
==========================================
  Files         170      170              
  Lines       64179    64207      +28     
==========================================
+ Hits        53955    54716     +761     
+ Misses      10224     9491     -733     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsalant22

Copy link
Copy Markdown
Contributor

@ramin4667 Can you add a unit test for this? Something as simple as grabbing the ComponentCatalog and verifying the number of components returned is the expected value I think would be sufficient.

@jsalant22

Copy link
Copy Markdown
Contributor

@ramin4667 This looks like it only shows the components that are in SysLib\EmitElements. Is it possible to also search the PersonalLib directory and show Emit components that the user has saved there? Preferably an optional argument to this (e.g. include_personal_lib=False)

@ramin4667

ramin4667 commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

@ramin4667 Can you add a unit test for this? Something as simple as grabbing the ComponentCatalog and verifying the number of components returned is the expected value I think would be sufficient.

@jsalant22 A unit test is added.

@jsalant22

Copy link
Copy Markdown
Contributor

@ramin4667 This looks like it only shows the components that are in SysLib\EmitElements. Is it possible to also search the PersonalLib directory and show Emit components that the user has saved there? Preferably an optional argument to this (e.g. include_personal_lib=False)

@ramin4667 We can make this a separate user story.

jsalant22
jsalant22 previously approved these changes May 29, 2025
Comment thread tests/system/solvers/test_26_emit.py Outdated
Comment thread tests/system/solvers/test_26_emit.py Outdated
Comment thread tests/system/solvers/test_26_emit.py Outdated
jsalant22
jsalant22 previously approved these changes May 29, 2025
@ramin4667

Copy link
Copy Markdown
Contributor Author

@ramin4667 This looks like it only shows the components that are in SysLib\EmitElements. Is it possible to also search the PersonalLib directory and show Emit components that the user has saved there? Preferably an optional argument to this (e.g. include_personal_lib=False)

@ramin4667 We can make this a separate user story.

@jsalant22 A control named include_personal_lib to switch the library to PersonalLib if true.

@jsalant22
jsalant22 merged commit db7d43e into main Jun 3, 2025
@jsalant22
jsalant22 deleted the FEAT__Add_function_to_EMIT_to_list_all_component_types branch June 3, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants