REFACTOR: Import nastran extension and tests - #6227
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Samuelopez-ansys
left a comment
There was a problem hiding this comment.
Maybe instead of using os.path, we could use pathlib?
Sure |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6227 +/- ##
==========================================
- Coverage 85.20% 85.20% -0.01%
==========================================
Files 170 170
Lines 64209 64332 +123
==========================================
+ Hits 54711 54815 +104
- Misses 9498 9517 +19 🚀 New features to boost your workflow:
|
|
@SMoraisAnsys Great job! I like it a lot, should we also test root.nametowidget("preview_button").invoke()? Or the toogle theme? Maybe we could add another test for this common funcionalities? I was thinking that maybe in a next PR, we could create a class to define the default UI, because then maybe we can start creating method to building common stuff like multitabs, buttons... following the same structure, what do you think? |
Maybe I'm missing something but the preview button and toggle button are tested in https://github.com/ansys/pyaedt/pull/6227/files#diff-ac52ccb11fa1ba48938746d6dbe8a83b26b7d455bb64077eee93ad579dd83161 I do agree with a follow-up PR where we create a defaut UI class. I'll handle it if that's ok with you |
Description
Refactoring of the import nastran extension where the extension has been updated to allow testing with tkinter direct interaction.
Issue linked
Associated to #6228
Checklist