Repository navigation
REFACTOR: Nastran import refactoring - #6236
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Alberto-DM
marked this pull request as draft
June 5, 2025 15:27
… nastran_import_refactoring
# Conflicts: # src/ansys/aedt/core/extensions/project/import_nastran.py # src/ansys/aedt/core/visualization/advanced/misc.py
final MANIFEST.in configuration
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6236 +/- ##
==========================================
- Coverage 82.65% 82.63% -0.03%
==========================================
Files 244 246 +2
Lines 77824 77603 -221
==========================================
- Hits 64329 64128 -201
+ Misses 13495 13475 -20 🚀 New features to boost your workflow:
|
Alberto-DM
marked this pull request as ready for review
June 13, 2025 22:46
Alberto-DM
enabled auto-merge (squash)
June 13, 2025 22:47
Samuelopez-ansys
marked this pull request as draft
September 4, 2025 17:57
auto-merge was automatically disabled
September 4, 2025 17:57
Pull request was converted to draft
Alberto-DM
marked this pull request as ready for review
September 25, 2025 15:19
Alberto-DM
enabled auto-merge (squash)
September 26, 2025 07:11
Samuelopez-ansys
approved these changes
Sep 26, 2025
Samuelopez-ansys
left a comment
Member
There was a problem hiding this comment.
Great job!
I would add the new settings here too:
https://github.com/ansys/pyaedt/blob/main/doc/source/User_guide/settings.rst
But it can be done in a new PR (please do it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Nastran import method has been completely refactored.
It has been moved out from visualization.advanced.misc and created a new module.
This module is compiled as pyd and imported in core.syslib.nastran_import.
nastran_import uses a method to dynamically inject helper functions defined in PyAEDT.
Two settings has been created to define the syslib module location and to provide to the user the possibility to specify a custom libraries location.
This refactoring has been done with the intent to generalize the inclusion of pyd in PyAEDT. A function to load dynamically the module with variable package location and name is provided.