Skip to content

REFACTOR: Nastran import refactoring - #6236

Merged
Alberto-DM merged 45 commits into
mainfrom
nastran_import_refactoring
Sep 26, 2025
Merged

Alberto-DM merged 45 commits into
mainfrom
nastran_import_refactoring

Conversation

@Alberto-DM

@Alberto-DM Alberto-DM commented Jun 5, 2025 •

Copy link
Copy Markdown
Contributor

Description

The Nastran import method has been completely refactored.
It has been moved out from visualization.advanced.misc and created a new module.
This module is compiled as pyd and imported in core.syslib.nastran_import.
nastran_import uses a method to dynamically inject helper functions defined in PyAEDT.
Two settings has been created to define the syslib module location and to provide to the user the possibility to specify a custom libraries location.
This refactoring has been done with the intent to generalize the inclusion of pyd in PyAEDT. A function to load dynamically the module with variable package location and name is provided.

@Alberto-DM
Alberto-DM requested a review from a team as a code owner June 5, 2025 15:25
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Alberto-DM
Alberto-DM marked this pull request as draft June 5, 2025 15:27
@github-actions github-actions Bot added the maintenance Package and maintenance related label Jun 6, 2025
@codecov

codecov Bot commented Jun 10, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.92248% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.63%. Comparing base (62eb0f3) to head (0e96c84).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6236      +/-   ##
==========================================
- Coverage   82.65%   82.63%   -0.03%     
==========================================
  Files         244      246       +2     
  Lines       77824    77603     -221     
==========================================
- Hits        64329    64128     -201     
+ Misses      13495    13475      -20     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alberto-DM
Alberto-DM marked this pull request as ready for review June 13, 2025 22:46
@Alberto-DM
Alberto-DM enabled auto-merge (squash) June 13, 2025 22:47
@Samuelopez-ansys
Samuelopez-ansys marked this pull request as draft September 4, 2025 17:57
auto-merge was automatically disabled September 4, 2025 17:57

Pull request was converted to draft

@Alberto-DM
Alberto-DM marked this pull request as ready for review September 25, 2025 15:19
@Alberto-DM
Alberto-DM enabled auto-merge (squash) September 26, 2025 07:11

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

I would add the new settings here too:

https://github.com/ansys/pyaedt/blob/main/doc/source/User_guide/settings.rst

But it can be done in a new PR (please do it)

@Alberto-DM
Alberto-DM merged commit 52633bc into main Sep 26, 2025
1 check passed
@Alberto-DM
Alberto-DM deleted the nastran_import_refactoring branch September 26, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants