REFACTOR: Extension architecture using common class#6238
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6238 +/- ##
==========================================
+ Coverage 85.22% 85.23% +0.01%
==========================================
Files 170 170
Lines 64364 64463 +99
==========================================
+ Hits 54855 54946 +91
- Misses 9509 9517 +8 🚀 New features to boost your workflow:
|
hui-zhou-a
reviewed
Jun 7, 2025
hui-zhou-a
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I like it a lot!
MaxJPRey
reviewed
Jun 8, 2025
MaxJPRey
reviewed
Jun 8, 2025
MaxJPRey
reviewed
Jun 8, 2025
Collaborator
|
Great code @SMoraisAnsys . |
Member
|
SUPER! |
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
hui-zhou-a
previously approved these changes
Jun 10, 2025
…aedt into refactor/extension-architecture
…aedt into refactor/extension-architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at refactoring the extension by providing a common class. This class encapsulate a few common behavior of the current extensions and it is used + tested to created the template extension.
Issue linked
Associated to #6228
Checklist