Skip to content

REFACTOR: Extension architecture using common class#6238

Merged
SMoraisAnsys merged 21 commits into
mainfrom
refactor/extension-architecture
Jun 11, 2025
Merged

REFACTOR: Extension architecture using common class#6238
SMoraisAnsys merged 21 commits into
mainfrom
refactor/extension-architecture

Conversation

@SMoraisAnsys

@SMoraisAnsys SMoraisAnsys commented Jun 6, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR aims at refactoring the extension by providing a common class. This class encapsulate a few common behavior of the current extensions and it is used + tested to created the template extension.

Issue linked

Associated to #6228

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner June 6, 2025 14:23
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys self-assigned this Jun 6, 2025
@codecov

codecov Bot commented Jun 6, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.53571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (629efaa) to head (dd03647).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6238      +/-   ##
==========================================
+ Coverage   85.22%   85.23%   +0.01%     
==========================================
  Files         170      170              
  Lines       64364    64463      +99     
==========================================
+ Hits        54855    54946      +91     
- Misses       9509     9517       +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hui-zhou-a hui-zhou-a left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like it a lot!

Comment thread src/ansys/aedt/core/extensions/misc.py Outdated
Comment thread tests/unit/extensions/test_extension_common.py
Comment thread src/ansys/aedt/core/extensions/misc.py Outdated
@MaxJPRey

MaxJPRey commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

Great code @SMoraisAnsys .

@SMoraisAnsys SMoraisAnsys marked this pull request as draft June 9, 2025 00:21
@Samuelopez-ansys

Copy link
Copy Markdown
Member

SUPER!

Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
hui-zhou-a
hui-zhou-a previously approved these changes Jun 10, 2025
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review June 10, 2025 19:28

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@SMoraisAnsys SMoraisAnsys merged commit e3a419d into main Jun 11, 2025
37 checks passed
@SMoraisAnsys SMoraisAnsys deleted the refactor/extension-architecture branch June 11, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants