Skip to content

FIX: Refactor Move IT extension with ExtensionCommon - #6280

Merged
Samuelopez-ansys merged 12 commits into
mainfrom
feat/issue_6273
Jun 19, 2025
Merged

FIX: Refactor Move IT extension with ExtensionCommon #6280
Samuelopez-ansys merged 12 commits into
mainfrom
feat/issue_6273

Conversation

@Samuelopez-ansys

@Samuelopez-ansys Samuelopez-ansys commented Jun 18, 2025

Copy link
Copy Markdown
Member

Description

Refactoring of the Move IT extension with the new Extension Common class.

Add unit test of the UI.

Issue linked

Close #6273

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the enhancement New features or code improvements label Jun 18, 2025
@codecov

codecov Bot commented Jun 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.27%. Comparing base (0aba0b3) to head (64fe82f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6280      +/-   ##
==========================================
+ Coverage   85.25%   85.27%   +0.01%     
==========================================
  Files         173      173              
  Lines       65269    65358      +89     
==========================================
+ Hits        55647    55732      +85     
- Misses       9622     9626       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys changed the title FIX: Move IT FIX: Refactor Move IT extension with ExtensionCommon Jun 18, 2025
@Samuelopez-ansys
Samuelopez-ansys marked this pull request as ready for review June 18, 2025 14:09
@Samuelopez-ansys
Samuelopez-ansys requested a review from a team as a code owner June 18, 2025 14:09

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for handling the refactoring of this extension @Samuelopez-ansys
I left some minor comments to address before merging

Comment thread src/ansys/aedt/core/extensions/hfss/move_it.py Outdated
Comment thread src/ansys/aedt/core/extensions/hfss/move_it.py Outdated
Comment thread src/ansys/aedt/core/extensions/hfss/move_it.py Outdated
Comment thread src/ansys/aedt/core/extensions/hfss/move_it.py Outdated
Comment thread tests/system/extensions/test_move_it.py Outdated
Comment thread tests/system/extensions/test_move_it.py Outdated
Comment thread tests/system/extensions/test_move_it.py Outdated
Comment thread tests/unit/extensions/test_move_it.py Outdated
@Samuelopez-ansys
Samuelopez-ansys enabled auto-merge (squash) June 19, 2025 12:53
@Samuelopez-ansys
Samuelopez-ansys merged commit 7fece27 into main Jun 19, 2025
@Samuelopez-ansys
Samuelopez-ansys deleted the feat/issue_6273 branch June 19, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Move IT extension

3 participants