Skip to content

FIX: Parametrics fix in add_from_file for Maxwell - #6299

Merged
gmalinve merged 8 commits into
mainfrom
fix/add_from_file_opti
Jun 24, 2025
Merged

gmalinve merged 8 commits into
mainfrom
fix/add_from_file_opti

Conversation

@gmalinve

Copy link
Copy Markdown
Contributor

Description

The method has a different implementation for Maxwell2D and Maxwell3D.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@gmalinve gmalinve self-assigned this Jun 23, 2025
@gmalinve
gmalinve requested a review from a team as a code owner June 23, 2025 13:24
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Jun 23, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions Bot added the bug Something isn't working label Jun 23, 2025
@codecov

codecov Bot commented Jun 23, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (e54714f) to head (c287fdd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6299      +/-   ##
==========================================
- Coverage   85.29%   85.28%   -0.02%     
==========================================
  Files         173      173              
  Lines       65331    65308      -23     
==========================================
- Hits        55724    55696      -28     
- Misses       9607     9612       +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gmalinve
gmalinve marked this pull request as draft June 23, 2025 15:28
@gmalinve
gmalinve marked this pull request as ready for review June 24, 2025 06:45
MaxJPRey
MaxJPRey previously approved these changes Jun 24, 2025

@MaxJPRey MaxJPRey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 24, 2025

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment, feel free to discard it :)

Comment thread src/ansys/aedt/core/modules/design_xploration.py Outdated
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@gmalinve
gmalinve merged commit adea30b into main Jun 24, 2025
@gmalinve
gmalinve deleted the fix/add_from_file_opti branch June 24, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in parametrics.add_from_file()

5 participants