FIX: Parametrics fix in add_from_file for Maxwell - #6299
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6299 +/- ##
==========================================
- Coverage 85.29% 85.28% -0.02%
==========================================
Files 173 173
Lines 65331 65308 -23
==========================================
- Hits 55724 55696 -28
- Misses 9607 9612 +5 🚀 New features to boost your workflow:
|
gmalinve
marked this pull request as draft
June 23, 2025 15:28
gmalinve
marked this pull request as ready for review
June 24, 2025 06:45
Samuelopez-ansys
previously approved these changes
Jun 24, 2025
SMoraisAnsys
previously approved these changes
Jun 24, 2025
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
gmalinve
dismissed stale reviews from SMoraisAnsys, Samuelopez-ansys, and MaxJPRey
via
June 24, 2025 12:15
c287fdd
Samuelopez-ansys
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The method has a different implementation for Maxwell2D and Maxwell3D.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist