Skip to content

FIX: Extension's unwanted desktop opening#6304

Merged
SMoraisAnsys merged 2 commits into
mainfrom
fix/extension-unwanted-desktop-opening
Jun 24, 2025
Merged

FIX: Extension's unwanted desktop opening#6304
SMoraisAnsys merged 2 commits into
mainfrom
fix/extension-unwanted-desktop-opening

Conversation

@SMoraisAnsys

Copy link
Copy Markdown
Collaborator

Description

A bug was introduced in #5966 where a user would have AEDT automatically opening to be closed right away when the extension did not open AEDT by default. This behavior was happening with the via_design.py extension where no AEDT extension is required by default and clicking on the close button triggered AEDT which was closed right after.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys self-assigned this Jun 24, 2025
@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner June 24, 2025 09:17
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label Jun 24, 2025
@codecov

codecov Bot commented Jun 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (e54714f) to head (9031938).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6304      +/-   ##
==========================================
- Coverage   85.29%   85.29%   -0.01%     
==========================================
  Files         173      173              
  Lines       65331    65331              
==========================================
- Hits        55724    55722       -2     
- Misses       9607     9609       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys enabled auto-merge (squash) June 24, 2025 09:35
@SMoraisAnsys SMoraisAnsys merged commit 37fc488 into main Jun 24, 2025
62 of 66 checks passed
@SMoraisAnsys SMoraisAnsys deleted the fix/extension-unwanted-desktop-opening branch June 24, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants