Skip to content

FIX: Notify VTK for changes in the animation loop - #6310

Merged
Samuelopez-ansys merged 12 commits into
mainfrom
6309-modelplotter-animate-functionality-not-working
Jun 30, 2025
Merged

FIX: Notify VTK for changes in the animation loop#6310
Samuelopez-ansys merged 12 commits into
mainfrom
6309-modelplotter-animate-functionality-not-working

Conversation

@eblanco-ansys

Copy link
Copy Markdown
Contributor

Description

Fixed animation issues in pyvista. It was necessary to notify VTK for the changes and refresh the view

Issue linked

#6309

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@eblanco-ansys
eblanco-ansys requested a review from a team as a code owner June 25, 2025 14:17
@eblanco-ansys eblanco-ansys linked an issue Jun 25, 2025 that may be closed by this pull request
2 tasks
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov

codecov Bot commented Jun 25, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (f806d87) to head (5cf03c9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6310      +/-   ##
==========================================
+ Coverage   85.25%   85.26%   +0.01%     
==========================================
  Files         173      173              
  Lines       65300    65306       +6     
==========================================
+ Hits        55670    55684      +14     
+ Misses       9630     9622       -8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/ansys/aedt/core/visualization/plot/pyvista.py Outdated
@Samuelopez-ansys
Samuelopez-ansys enabled auto-merge (squash) June 30, 2025 10:51
@Samuelopez-ansys
Samuelopez-ansys merged commit 5a6f5bb into main Jun 30, 2025
36 of 37 checks passed
@Samuelopez-ansys
Samuelopez-ansys deleted the 6309-modelplotter-animate-functionality-not-working branch June 30, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModelPlotter animate functionality not working

4 participants