Skip to content

FIX: lsf-job-submission-failure#6318

Merged
Samuelopez-ansys merged 6 commits into
mainfrom
svandenb-dev-patch-1
Jun 27, 2025
Merged

FIX: lsf-job-submission-failure#6318
Samuelopez-ansys merged 6 commits into
mainfrom
svandenb-dev-patch-1

Conversation

@svandenb-dev

@svandenb-dev svandenb-dev commented Jun 26, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR is fixing lsf job submission failure due to Pathlib.Path passed as argument into AEDT native api instead of string causing failure.

closing #6319

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@svandenb-dev svandenb-dev requested a review from a team as a code owner June 26, 2025 15:27
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev self-assigned this Jun 26, 2025
@svandenb-dev svandenb-dev linked an issue Jun 26, 2025 that may be closed by this pull request
2 tasks
@codecov

codecov Bot commented Jun 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (cd1f169) to head (e9855e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6318      +/-   ##
==========================================
- Coverage   85.26%   84.74%   -0.53%     
==========================================
  Files         173      173              
  Lines       65294    65294              
==========================================
- Hits        55672    55331     -341     
- Misses       9622     9963     +341     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys

Copy link
Copy Markdown
Member

@svandenb-dev why not just str(destination_reg)?

Comment thread src/ansys/aedt/core/desktop.py Outdated
svandenb-dev and others added 3 commits June 27, 2025 09:06
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>

@Devin-Crawford Devin-Crawford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread src/ansys/aedt/core/desktop.py
Comment thread src/ansys/aedt/core/desktop.py Outdated
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) June 27, 2025 07:51
@Samuelopez-ansys Samuelopez-ansys merged commit e6725d0 into main Jun 27, 2025
36 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the svandenb-dev-patch-1 branch June 27, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LSF submit job failure

5 participants