Skip to content

REFACTOR: Cutout extension - #6321

Merged
SMoraisAnsys merged 25 commits into
mainfrom
refactor/cutout-extension
Jul 10, 2025
Merged

REFACTOR: Cutout extension#6321
SMoraisAnsys merged 25 commits into
mainfrom
refactor/cutout-extension

Conversation

@SMoraisAnsys

@SMoraisAnsys SMoraisAnsys commented Jun 27, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR refactors the cutout extensions and adds test to it.

Issue linked

Close #6288

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys self-assigned this Jun 27, 2025
Comment thread src/ansys/aedt/core/extensions/misc.py Outdated
@codecov

codecov Bot commented Jun 27, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.79769% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.37%. Comparing base (091eb1c) to head (42e2b25).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6321      +/-   ##
==========================================
+ Coverage   85.34%   85.37%   +0.02%     
==========================================
  Files         175      175              
  Lines       65983    66143     +160     
==========================================
+ Hits        56316    56467     +151     
- Misses       9667     9676       +9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys
SMoraisAnsys marked this pull request as ready for review July 7, 2025 07:28
@SMoraisAnsys
SMoraisAnsys requested a review from a team as a code owner July 7, 2025 07:28
maxcapodi78
maxcapodi78 previously approved these changes Jul 7, 2025

@maxcapodi78 maxcapodi78 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Thank you for your refactoring

Comment thread src/ansys/aedt/core/extensions/misc.py Outdated

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys
SMoraisAnsys merged commit 112373c into main Jul 10, 2025
@SMoraisAnsys
SMoraisAnsys deleted the refactor/cutout-extension branch July 10, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REFACOT: Extension cutout and improve tests

4 participants