Skip to content

REFACTOR: configure layout - #6328

Merged
Samuelopez-ansys merged 15 commits into
mainfrom
refactor-configure-layout
Jun 30, 2025
Merged

REFACTOR: configure layout#6328
Samuelopez-ansys merged 15 commits into
mainfrom
refactor-configure-layout

Conversation

@hui-zhou-a

@hui-zhou-a hui-zhou-a commented Jun 28, 2025

Copy link
Copy Markdown
Contributor
  • Add support for relative path
  • remove the test on help links as it leads to chicken and egg problem
  • Fix working directory problem when launch from AEDT
  • Add support for loading configuration to active design

@hui-zhou-a
hui-zhou-a requested a review from a team as a code owner June 28, 2025 06:33
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@hui-zhou-a hui-zhou-a linked an issue Jun 28, 2025 that may be closed by this pull request
2 tasks
@codecov

codecov Bot commented Jun 28, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.45455% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.37%. Comparing base (cbd81f8) to head (7c930fa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6328      +/-   ##
==========================================
+ Coverage   85.35%   85.37%   +0.02%     
==========================================
  Files         175      175              
  Lines       65759    65797      +38     
==========================================
+ Hits        56128    56174      +46     
+ Misses       9631     9623       -8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements, I've got a few comments on the changes.

Comment thread src/ansys/aedt/core/extensions/project/configure_layout.py Outdated
Comment thread src/ansys/aedt/core/extensions/project/configure_layout.py Outdated
Comment thread src/ansys/aedt/core/extensions/project/configure_layout.py Outdated
Comment thread tests/system/extensions/test_configure_layout.py
@hui-zhou-a
hui-zhou-a requested a review from SMoraisAnsys June 30, 2025 07:22
Comment thread src/ansys/aedt/core/extensions/project/configure_layout.py Outdated

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a hui-zhou-a linked an issue Jun 30, 2025 that may be closed by this pull request
@Samuelopez-ansys
Samuelopez-ansys merged commit d34e771 into main Jun 30, 2025
@Samuelopez-ansys
Samuelopez-ansys deleted the refactor-configure-layout branch June 30, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In New Edb Configuration add ability to run on an active design Bug located in Configure Layout extension

4 participants