Skip to content

FIX: Skip Move on Circuit if it is running on linux in non-graphical mode#6332

Merged
maxcapodi78 merged 8 commits into
mainfrom
fix_linux_move
Jun 30, 2025
Merged

FIX: Skip Move on Circuit if it is running on linux in non-graphical mode#6332
maxcapodi78 merged 8 commits into
mainfrom
fix_linux_move

Conversation

@maxcapodi78

Copy link
Copy Markdown
Member

Description

Due to a bug in Circuit: Skip Move on Circuit if it is running on linux in non-graphical mode

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@maxcapodi78 maxcapodi78 requested a review from a team as a code owner June 30, 2025 07:28
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label Jun 30, 2025

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 30, 2025

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Any chance that this gets fixed soon ? Should we leave an open issue to track this wrong behavior and close it (and remove this skip) once it's fixed ?

@Samuelopez-ansys

Copy link
Copy Markdown
Member

@SMoraisAnsys Done #6333

@codecov

codecov Bot commented Jun 30, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (ff46f1e) to head (41cb01d).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6332      +/-   ##
==========================================
+ Coverage   85.25%   85.26%   +0.01%     
==========================================
  Files         173      173              
  Lines       65295    65300       +5     
==========================================
+ Hits        55666    55677      +11     
+ Misses       9629     9623       -6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 30, 2025
Comment thread src/ansys/aedt/core/modeler/schematic.py
Comment thread tests/system/general/test_21_Circuit.py
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Samuelopez-ansys and others added 2 commits June 30, 2025 10:36
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@maxcapodi78 maxcapodi78 enabled auto-merge (squash) June 30, 2025 08:54
@maxcapodi78 maxcapodi78 merged commit f806d87 into main Jun 30, 2025
37 of 38 checks passed
@maxcapodi78 maxcapodi78 deleted the fix_linux_move branch June 30, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants