FEAT: Install pyaedt via uv - #6338
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6338 +/- ##
=======================================
Coverage 82.44% 82.44%
=======================================
Files 242 242
Lines 77004 77004
=======================================
Hits 63485 63485
Misses 13519 13519 🚀 New features to boost your workflow:
|
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Could you give a try at making the whole project moving to uv instead of only this installation file ? Also, could you consider using UV_HTTP_TIMEOUT in order to keep the previous behavior with ``--default-timeout` ? It has a larger scope but if I understand well the documentation it should be helping for this.
There was a problem hiding this comment.
Here are some comments, thanks for the contribution !
Note that we might have issues when using pyaedt with uv. In particular for those still leveraging the dotnet target.
See ansys/pymechanical#1143 and the associated uv issue astral-sh/python-build-standalone#596
…-to-use-uv-package-manager
|
Should we merge this PR? PyAEDT issues using uv can be avoided creating the venv in the traditional way and installing packages via uv. With the actual implementation should work fine |
|
@eblanco-ansys The main issue is about the offline installation. Is this solved? If uv is not installed in the venv , how the offline installation would work? We could add uv to the dependencies of pyaedt or at least to the wheelhouses @SMoraisAnsys any thoughts? |
Adding |
…-to-use-uv-package-manager
All the previous concerns were related to how the venv is created. If we create the venv in the traditional way and install everything via uv, it should be fine. @tusharbana-ansys figured out this workaround |
…-to-use-uv-package-manager
Description
Use uv to install pyaedt dependencies. Implemented changes
python -m venvuntil Package seems not to work pymechanical#1143 and the associated uv issue Windows: OpenSSL installed DLL name differs from CPython, affecting extension modules astral-sh/python-build-standalone#596 are resolveduvis installed firstly and the other packages are installed viauv pip install(a lot faster)uvis intalled firstly. We then useuvto install the other packages inside the wheel.With these changes we reduce a lot the overall installation time, up to 5 times.
Other minor changes:
Issue linked
#6317
Checklist