Skip to content

FEAT: Assign wave port in Driven Terminal - #6358

Merged
Samuelopez-ansys merged 8 commits into
mainfrom
feat/issue_6357
Jul 10, 2025
Merged

Samuelopez-ansys merged 8 commits into
mainfrom
feat/issue_6357

Conversation

@Samuelopez-ansys

Copy link
Copy Markdown
Member

Description

Assign wave port in driven terminal is available since 2024R1.

Issue linked

Close #6357

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

Samuelopez-ansys added 3 commits July 7, 2025 10:56
# Conflicts:
#	src/ansys/aedt/core/hfss.py
#	tests/system/general/test_20_HFSS.py
@Samuelopez-ansys
Samuelopez-ansys requested a review from a team as a code owner July 7, 2025 09:08
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the enhancement New features or code improvements label Jul 7, 2025
@codecov

codecov Bot commented Jul 7, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (710ce3a) to head (17f98bc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6358      +/-   ##
==========================================
- Coverage   85.36%   85.36%   -0.01%     
==========================================
  Files         175      175              
  Lines       65989    65980       -9     
==========================================
- Hits        56333    56321      -12     
- Misses       9656     9659       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys
Samuelopez-ansys merged commit e1f9211 into main Jul 10, 2025
@Samuelopez-ansys
Samuelopez-ansys deleted the feat/issue_6357 branch July 10, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add creation of modal waveport in driven terminal designs

3 participants