FEAT: Control order connection between coil terminals in Maxwell3D TransientAPhiFormulation - #6360
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6360 +/- ##
==========================================
+ Coverage 84.27% 85.37% +1.10%
==========================================
Files 175 175
Lines 65983 65989 +6
==========================================
+ Hits 55606 56337 +731
+ Misses 10377 9652 -725 🚀 New features to boost your workflow:
|
nunesanderson
previously approved these changes
Jul 7, 2025
nunesanderson
left a comment
nunesanderson
left a comment
Contributor
There was a problem hiding this comment.
Hi @jvela018 . I left one quick comment.
Thank you!
Anderson
SMoraisAnsys
reviewed
Jul 7, 2025
…s' into feat/winding/order_coil_terminals
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
gmalinve
reviewed
Jul 8, 2025
gmalinve
reviewed
Jul 8, 2025
gmalinve
reviewed
Jul 8, 2025
gmalinve
reviewed
Jul 8, 2025
gmalinve
reviewed
Jul 8, 2025
gmalinve
reviewed
Jul 8, 2025
gmalinve
reviewed
Jul 8, 2025
gmalinve
previously requested changes
Jul 8, 2025
gmalinve
left a comment
gmalinve
left a comment
Contributor
There was a problem hiding this comment.
I left some comments. Could you also please link the PR to its issue? thanks! :)
…s' into feat/winding/order_coil_terminals # Conflicts: # src/ansys/aedt/core/maxwell.py
jvela018
dismissed
gmalinve’s stale review
July 8, 2025 08:54
changes were made accordingly to previous comments
gmalinve
reviewed
Jul 8, 2025
gmalinve
reviewed
Jul 8, 2025
gmalinve
reviewed
Jul 8, 2025
Co-authored-by: Giulia Malinverno <103059376+gmalinve@users.noreply.github.com>
gmalinve
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This feature enables the user to create custom connection order between different coil terminals in the same winding definition
Issue linked
#5328
Checklist