REFACTOR: Point cloud extension and tests#6372
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6372 +/- ##
========================================
Coverage 85.42% 85.42%
========================================
Files 175 175
Lines 66390 66530 +140
========================================
+ Hits 56714 56836 +122
- Misses 9676 9694 +18 🚀 New features to boost your workflow:
|
… template and associated tests
Member
|
Hi @ecoussoux-ansys great job! Please could you try to increase the coverage? I think only a few cases are missed, and we could try to reach the 100%. |
Samuelopez-ansys
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the guidelines introduced in #6303 and as part of the contributions on #6228 :
ExtensionCommonclass (introduced in REFACTOR: Extension architecture using common class #6238 ),Close #6366
Minimal changes are also introduced in this PR with the aim of simplifying the definition of unit tests for the "move it" extension in
tests/unit/extensions/test_move_it.py.A few comments and docstrings are also refined in files defining the template extension and the tests associated with it.