Skip to content

REFACTOR: Point cloud extension and tests#6372

Merged
Samuelopez-ansys merged 14 commits into
mainfrom
refactor/point-cloud-extension
Jul 17, 2025
Merged

REFACTOR: Point cloud extension and tests#6372
Samuelopez-ansys merged 14 commits into
mainfrom
refactor/point-cloud-extension

Conversation

@ecoussoux-ansys
Copy link
Copy Markdown
Contributor

@ecoussoux-ansys ecoussoux-ansys commented Jul 9, 2025

Following the guidelines introduced in #6303 and as part of the contributions on #6228 :

Close #6366

Minimal changes are also introduced in this PR with the aim of simplifying the definition of unit tests for the "move it" extension in tests/unit/extensions/test_move_it.py.
A few comments and docstrings are also refined in files defining the template extension and the tests associated with it.

@ecoussoux-ansys ecoussoux-ansys self-assigned this Jul 9, 2025
@ecoussoux-ansys ecoussoux-ansys added the enhancement New features or code improvements label Jul 9, 2025
@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 85.53459% with 23 lines in your changes missing coverage. Please review.

Project coverage is 85.42%. Comparing base (c08417b) to head (44335dc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6372    +/-   ##
========================================
  Coverage   85.42%   85.42%            
========================================
  Files         175      175            
  Lines       66390    66530   +140     
========================================
+ Hits        56714    56836   +122     
- Misses       9676     9694    +18     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ecoussoux-ansys ecoussoux-ansys marked this pull request as ready for review July 15, 2025 11:42
@ecoussoux-ansys ecoussoux-ansys requested a review from a team as a code owner July 15, 2025 11:42
@Samuelopez-ansys
Copy link
Copy Markdown
Member

Hi @ecoussoux-ansys great job! Please could you try to increase the coverage? I think only a few cases are missed, and we could try to reach the 100%.

@Samuelopez-ansys Samuelopez-ansys merged commit c42e03d into main Jul 17, 2025
37 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/point-cloud-extension branch July 17, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate point cloud generator extension

3 participants