Skip to content

REFACTOR: 6375 migrate shielding effectiveness extension#6379

Merged
Samuelopez-ansys merged 22 commits into
mainfrom
6375-migrate-shielding-effectiveness-extension
Aug 7, 2025
Merged

REFACTOR: 6375 migrate shielding effectiveness extension#6379
Samuelopez-ansys merged 22 commits into
mainfrom
6375-migrate-shielding-effectiveness-extension

Conversation

@eblanco-ansys

Copy link
Copy Markdown
Contributor

Description

  • Migrated shielding effectiveness extension to new standard
  • Added tests
  • Small UI improvement adding a selector

Issue linked

#6375

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@eblanco-ansys eblanco-ansys requested a review from a team as a code owner July 10, 2025 09:19
@eblanco-ansys eblanco-ansys linked an issue Jul 10, 2025 that may be closed by this pull request
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@eblanco-ansys eblanco-ansys self-assigned this Jul 10, 2025
@eblanco-ansys eblanco-ansys changed the title 6375 migrate shielding effectiveness extension REFACTOR: 6375 migrate shielding effectiveness extension Jul 11, 2025
@codecov

codecov Bot commented Jul 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.72611% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.36%. Comparing base (ef9d62d) to head (f674c35).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6379      +/-   ##
==========================================
+ Coverage   82.32%   82.36%   +0.03%     
==========================================
  Files         231      231              
  Lines       74210    74340     +130     
==========================================
+ Hits        61093    61227     +134     
+ Misses      13117    13113       -4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft July 24, 2025 09:04
@eblanco-ansys eblanco-ansys marked this pull request as ready for review August 5, 2025 16:06

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) August 7, 2025 13:30
@Samuelopez-ansys Samuelopez-ansys merged commit 8d1a4ae into main Aug 7, 2025
38 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the 6375-migrate-shielding-effectiveness-extension branch August 7, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate shielding effectiveness extension

3 participants