Skip to content

FIX: Refactoring of component_array creation - #6383

Merged
Samuelopez-ansys merged 10 commits into
mainfrom
fix/component_array
Jul 14, 2025
Merged

FIX: Refactoring of component_array creation#6383
Samuelopez-ansys merged 10 commits into
mainfrom
fix/component_array

Conversation

@maxcapodi78

Copy link
Copy Markdown
Member

Description

Refactoring of component_array creation:

  • add create classmethod in ComponentArray class
  • deprecated method add_3d_component_array_from_json in Hfss
  • added new method create_component_array in Hfss

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

- add create classmethod in ComponentArray class
- deprecated method add_3d_component_array_from_json in Hfss
- added new method create_component_array in Hfss
@maxcapodi78
maxcapodi78 requested a review from a team as a code owner July 10, 2025 15:15
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label Jul 10, 2025
@codecov

codecov Bot commented Jul 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (4db9708) to head (5815f86).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6383      +/-   ##
==========================================
+ Coverage   85.37%   85.40%   +0.02%     
==========================================
  Files         175      175              
  Lines       66137    66157      +20     
==========================================
+ Hits        56467    56502      +35     
+ Misses       9670     9655      -15     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys
Samuelopez-ansys merged commit 6d6d39f into main Jul 14, 2025
37 checks passed
@Samuelopez-ansys
Samuelopez-ansys deleted the fix/component_array branch July 14, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants