Skip to content

REFACTOR: Power map from csv extension - #6388

Merged
SMoraisAnsys merged 12 commits into
mainfrom
refactor/power-map-from-csv-extension
Jul 16, 2025
Merged

SMoraisAnsys merged 12 commits into
mainfrom
refactor/power-map-from-csv-extension

Conversation

@SMoraisAnsys

@SMoraisAnsys SMoraisAnsys commented Jul 11, 2025 •

Copy link
Copy Markdown
Collaborator

Description

On top of the refactoring, some logic has been added to check the content of the provided file and warn the user if the data is incomplete.

Issue linked

Close #6377
Close #6405

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys self-assigned this Jul 11, 2025
@SMoraisAnsys
SMoraisAnsys requested a review from a team as a code owner July 11, 2025 10:06
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov

codecov Bot commented Jul 11, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.12403% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.43%. Comparing base (112373c) to head (88ed6d4).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6388      +/-   ##
==========================================
+ Coverage   85.37%   85.43%   +0.05%     
==========================================
  Files         175      175              
  Lines       66135    66477     +342     
==========================================
+ Hits        56464    56794     +330     
- Misses       9671     9683      +12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys
SMoraisAnsys merged commit 280d18f into main Jul 16, 2025
@SMoraisAnsys
SMoraisAnsys deleted the refactor/power-map-from-csv-extension branch July 16, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in extract_info() from ansys.aedt.core.extensions.icepak.power_map_from_csv Migrate power map from csv extension (Icepak)

3 participants