Repository navigation
REFACTOR: Scheduler logic - #6398
Closed
SMoraisAnsys wants to merge 14 commits into
Closed
SMoraisAnsys wants to merge 14 commits into
SMoraisAnsys wants to merge 14 commits into
Conversation
- Use Job_Settings_Template.txt as a template for the Job_Settings.areg. - The Job_Settings will be managed in the class JobSettings
- Use Job_Settings_Template.txt as a template for the Job_Settings.areg. - The Job_Settings will be managed in the class JobSettings
- Update settings.py to use HPC settings in scheduler.py - Start deprecating lsf-specific settings in settings.py - Automatically retrieve the executable. Added method 'get_aedt_exe()' in scheduler.py - Added docstring for JobSettings - Updated some default Job values. - Add self-consistency for dependent parameters (tasks, cores, nodes)
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
- Add _hpc_method property according to guidance from development. - Add logic to update _hpc_method depending on updated properties.
Ensure consistency among cores_per_task, num_cores and num_tasks.
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main idea is to split the submission attributes into two classes. On for the resources where there are a few checks performed and adjustement performed if needed (only triggered when writting the AREG file). If the user provided non aligned values, the class raises an exception when trying to write the AREG file.
Issue linked
Related to #6316
Checklist