CHORE: Rename numbers.py into numbers_utils.py#6412
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6412 +/- ##
==========================================
- Coverage 85.41% 85.07% -0.34%
==========================================
Files 175 176 +1
Lines 66282 66535 +253
==========================================
- Hits 56612 56607 -5
- Misses 9670 9928 +258 🚀 New features to boost your workflow:
|
Samuelopez-ansys
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes consist in renaming
src/ansys/core/generic/numbers.pyintosrc/ansys/core/generic/numbers_utils.py. The reason for that is explained below.While coding I encountered the following stack trace error:
This is caused by the fact the we have a file named numbers.py in generic and it conflicts with the python numbers module. Therefore, if any module in generic folder has a need for it (direct or transitive) we would end up with such error. It can be easily reproduced by creating a dummy file in generic and calling
from ansys.aedt.core.aedt_logger import pyaedt_logger as loggerIssue linked
None
Checklist