Repository navigation
FIX: Support for Maxwell Transient APhi Solver renaming in 2025R2 - #6414
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6414 +/- ##
==========================================
+ Coverage 84.36% 85.43% +1.07%
==========================================
Files 175 175
Lines 66477 66479 +2
==========================================
+ Hits 56080 56795 +715
+ Misses 10397 9684 -713 🚀 New features to boost your workflow:
|
gmalinve
reviewed
Jul 15, 2025
gmalinve
reviewed
Jul 15, 2025
gmalinve
reviewed
Jul 15, 2025
gmalinve
reviewed
Jul 15, 2025
gmalinve
reviewed
Jul 15, 2025
Co-authored-by: Giulia Malinverno <103059376+gmalinve@users.noreply.github.com>
Co-authored-by: Giulia Malinverno <103059376+gmalinve@users.noreply.github.com>
Co-authored-by: Giulia Malinverno <103059376+gmalinve@users.noreply.github.com>
Co-authored-by: Giulia Malinverno <103059376+gmalinve@users.noreply.github.com>
Co-authored-by: Giulia Malinverno <103059376+gmalinve@users.noreply.github.com>
Member
|
@jvela018 I am running this branch in 2025R2 to verify that it works. Thank you for your fast refactoring! |
SMoraisAnsys
previously approved these changes
Jul 17, 2025
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, I left a few minor comments.
Thanks for modifying the tests, rendering the main windows isn't required.
…ing' into fix/maxwell-transient-aphi-renaming
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
…ing' into fix/maxwell-transient-aphi-renaming
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
…ing' into fix/maxwell-transient-aphi-renaming
Member
|
@SMoraisAnsys @jvela018 I had to add a few things that were also breaking the UT in 2025R2. Please review it again. |
Samuelopez-ansys
approved these changes
Jul 17, 2025
Samuelopez-ansys
left a comment
Samuelopez-ansys
left a comment
Member
There was a problem hiding this comment.
LGTM. PyAEDT is compatible again with 2025R2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6413