Skip to content

REFACTOR: Enforce design check in extensions - #6433

Merged
Samuelopez-ansys merged 7 commits into
mainfrom
refactor/enforce-design-check-in-extensions
Jul 19, 2025
Merged

Samuelopez-ansys merged 7 commits into
mainfrom
refactor/enforce-design-check-in-extensions

Conversation

@SMoraisAnsys

@SMoraisAnsys SMoraisAnsys commented Jul 18, 2025 •

Copy link
Copy Markdown
Collaborator

Description

Enforce design checking in extensions and refactor the tests to avoid useless mock, and define common fixtures.

Issue linked

Related to #5516

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys
SMoraisAnsys requested a review from a team as a code owner July 18, 2025 13:59
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys
SMoraisAnsys force-pushed the refactor/enforce-design-check-in-extensions branch from 2b4a53a to 4ab3035 Compare July 18, 2025 14:00
@codecov

codecov Bot commented Jul 18, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.12%. Comparing base (ae51af8) to head (2440990).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6433      +/-   ##
==========================================
- Coverage   85.13%   85.12%   -0.01%     
==========================================
  Files         176      176              
  Lines       66944    66963      +19     
==========================================
+ Hits        56990    57004      +14     
- Misses       9954     9959       +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Samuelopez-ansys
Samuelopez-ansys enabled auto-merge (squash) July 19, 2025 15:22
@Samuelopez-ansys
Samuelopez-ansys merged commit 67d9e0c into main Jul 19, 2025
@Samuelopez-ansys
Samuelopez-ansys deleted the refactor/enforce-design-check-in-extensions branch July 19, 2025 21:10
@SMoraisAnsys

Copy link
Copy Markdown
Collaborator Author

Great!

Thanks for fixing the unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants