Skip to content

FIX: Import CAD with None value in control file - #6436

Merged
Samuelopez-ansys merged 2 commits into
mainfrom
fix/import_brd_bug
Jul 19, 2025
Merged

Samuelopez-ansys merged 2 commits into
mainfrom
fix/import_brd_bug

Conversation

@Samuelopez-ansys

Copy link
Copy Markdown
Member

Description

If the control file (xml_path) is None, then Path raises an exception. Now it is checking if the value is None.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys
Samuelopez-ansys requested a review from a team as a code owner July 18, 2025 15:24
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys changed the title FIX: Import CAD with None value in contro file FIX: Import CAD with None value in control file Jul 18, 2025
@github-actions github-actions Bot added the bug Something isn't working label Jul 18, 2025
@codecov

codecov Bot commented Jul 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.11%. Comparing base (ebd0ebb) to head (5caa475).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6436      +/-   ##
==========================================
- Coverage   85.12%   85.11%   -0.01%     
==========================================
  Files         176      176              
  Lines       66944    66944              
==========================================
- Hits        56983    56982       -1     
- Misses       9961     9962       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys
Samuelopez-ansys merged commit 0e5b0bf into main Jul 19, 2025
@Samuelopez-ansys
Samuelopez-ansys deleted the fix/import_brd_bug branch July 19, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants