Skip to content

FIX: Use regex to check installed ansysem versions#6453

Merged
Samuelopez-ansys merged 6 commits into
mainfrom
handle-version-list
Jul 23, 2025
Merged

FIX: Use regex to check installed ansysem versions#6453
Samuelopez-ansys merged 6 commits into
mainfrom
handle-version-list

Conversation

@skandak-ansys

@skandak-ansys skandak-ansys commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Using regex to check for installed ansysem version will prevent unexpected issues.
For example, when an env var named ANSYSEM_ROOT_PATH is present, instantiating a Hfss3dLayout or a desktop object was failing. This is now fixed
Fixes #6452
Fixes #6430

@skandak-ansys
skandak-ansys requested a review from a team as a code owner July 22, 2025 21:46
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@skandak-ansys skandak-ansys changed the title Use regex to check installed ansysem versions FIX: Use regex to check installed ansysem versions Jul 22, 2025
@codecov

codecov Bot commented Jul 22, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.45%. Comparing base (eb196b3) to head (d2a310a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6453      +/-   ##
==========================================
+ Coverage   76.69%   82.45%   +5.76%     
==========================================
  Files         230      230              
  Lines       73681    73678       -3     
==========================================
+ Hits        56506    60748    +4242     
+ Misses      17175    12930    -4245     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skandak-ansys @Samuelopez-ansys I've extended the PR because there was another issue that this PR and linked issues highlighted. The previous changes didn't directly handle the problem but they strengthen the way to retrieve the versions so LGTM :)

@Samuelopez-ansys
Samuelopez-ansys enabled auto-merge (squash) July 23, 2025 17:44
@Samuelopez-ansys
Samuelopez-ansys merged commit 43e0311 into main Jul 23, 2025
38 checks passed
@Samuelopez-ansys
Samuelopez-ansys deleted the handle-version-list branch July 23, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve getter method for identifying installed ansysem versions ANSYSEM_ROOT_PATH environment variable prevents PyAEDT from launching AEDT

4 participants