FIX: Use regex to check installed ansysem versions#6453
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6453 +/- ##
==========================================
+ Coverage 76.69% 82.45% +5.76%
==========================================
Files 230 230
Lines 73681 73678 -3
==========================================
+ Hits 56506 60748 +4242
+ Misses 17175 12930 -4245 🚀 New features to boost your workflow:
|
SMoraisAnsys
approved these changes
Jul 23, 2025
SMoraisAnsys
left a comment
Collaborator
There was a problem hiding this comment.
@skandak-ansys @Samuelopez-ansys I've extended the PR because there was another issue that this PR and linked issues highlighted. The previous changes didn't directly handle the problem but they strengthen the way to retrieve the versions so LGTM :)
Samuelopez-ansys
enabled auto-merge (squash)
July 23, 2025 17:44
Samuelopez-ansys
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using regex to check for installed ansysem version will prevent unexpected issues.
For example, when an env var named ANSYSEM_ROOT_PATH is present, instantiating a Hfss3dLayout or a desktop object was failing. This is now fixed
Fixes #6452
Fixes #6430