Skip to content

FIX: Icepak boundary update is missing - #6483

Merged
Samuelopez-ansys merged 5 commits into
mainfrom
fix/issue_6482
Aug 6, 2025
Merged

FIX: Icepak boundary update is missing#6483
Samuelopez-ansys merged 5 commits into
mainfrom
fix/issue_6482

Conversation

@siva-krishnaswamy

@siva-krishnaswamy siva-krishnaswamy commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

boundary is not updated even after the properties are changed. So the project still shows the old value.

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Close #6482

Checklist

  • [x ] I have tested my changes locally.
  • [x ] I have added necessary documentation or updated existing documentation.
  • [x ] I have followed the coding style guidelines of this project.
  • [x ] I have added appropriate tests (unit, integration, system).
  • [x ] I have reviewed my changes before submitting this pull request.
  • [ x] I have linked the issue or issues that are solved by the PR if any.
  • [ x] I have agreed with the Contributor License Agreement (CLA).

…undary is not updated. So the project still shows the old value.
@siva-krishnaswamy
siva-krishnaswamy requested a review from a team as a code owner July 30, 2025 14:58
@github-actions github-actions Bot added the bug Something isn't working label Jul 30, 2025
@siva-krishnaswamy siva-krishnaswamy changed the title fix for issue 6482. boundary update is missing FIX: fix for issue 6482. boundary update is missing Jul 31, 2025
@codecov

codecov Bot commented Jul 31, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.32%. Comparing base (d16678c) to head (6820191).
⚠️ Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6483      +/-   ##
==========================================
- Coverage   82.32%   82.32%   -0.01%     
==========================================
  Files         231      231              
  Lines       74209    74210       +1     
==========================================
- Hits        61094    61093       -1     
- Misses      13115    13117       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SMoraisAnsys
SMoraisAnsys previously approved these changes Aug 2, 2025

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MaxJPRey
MaxJPRey previously approved these changes Aug 4, 2025
@Samuelopez-ansys Samuelopez-ansys changed the title FIX: fix for issue 6482. boundary update is missing FIX: Icepak boundary update is missing Aug 4, 2025
@Samuelopez-ansys
Samuelopez-ansys enabled auto-merge (squash) August 4, 2025 10:04
@Samuelopez-ansys
Samuelopez-ansys merged commit 90cccb8 into main Aug 6, 2025
65 of 67 checks passed
@Samuelopez-ansys
Samuelopez-ansys deleted the fix/issue_6482 branch August 6, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in configuration boundary condition update

5 participants