Skip to content

FIX: Get evalauted value with correct unit scale - #6492

Merged
Samuelopez-ansys merged 12 commits into
mainfrom
fix/issue_6491
Aug 6, 2025
Merged

Samuelopez-ansys merged 12 commits into
mainfrom
fix/issue_6491

Conversation

@Samuelopez-ansys

Copy link
Copy Markdown
Member

Description

The obtained value was not scaled correctly.

Issue linked

Close #6491

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys
Samuelopez-ansys requested a review from a team as a code owner August 5, 2025 07:54
@github-actions github-actions Bot added the bug Something isn't working label Aug 5, 2025
@codecov

codecov Bot commented Aug 5, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.32%. Comparing base (90cccb8) to head (1ae5727).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6492   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files         231      231           
  Lines       74210    74210           
=======================================
+ Hits        61092    61095    +3     
+ Misses      13118    13115    -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nunesanderson
nunesanderson previously approved these changes Aug 5, 2025
Comment thread src/ansys/aedt/core/modules/boundary/maxwell_boundary.py Outdated
hui-zhou-a
hui-zhou-a previously approved these changes Aug 5, 2025

@hui-zhou-a hui-zhou-a left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Devin-Crawford
Devin-Crawford previously approved these changes Aug 6, 2025

@Devin-Crawford Devin-Crawford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread src/ansys/aedt/core/modules/boundary/maxwell_boundary.py Outdated
Comment thread src/ansys/aedt/core/application/analysis.py Outdated
Co-authored-by: Devin <38879940+Devin-Crawford@users.noreply.github.com>
Samuelopez-ansys and others added 2 commits August 6, 2025 08:58
Co-authored-by: Devin <38879940+Devin-Crawford@users.noreply.github.com>

@Devin-Crawford Devin-Crawford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samuelopez-ansys
Samuelopez-ansys merged commit ef9d62d into main Aug 6, 2025
@Samuelopez-ansys
Samuelopez-ansys deleted the fix/issue_6491 branch August 6, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in get_evaluated_value function

5 participants