Skip to content

REFACTOR: Extension Configure Layout - #6552

Merged
hui-zhou-a merged 7 commits into
mainfrom
refactor-configure-layout-2
Aug 20, 2025
Merged

hui-zhou-a merged 7 commits into
mainfrom
refactor-configure-layout-2

Conversation

@hui-zhou-a

Copy link
Copy Markdown
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@hui-zhou-a
hui-zhou-a requested a review from a team as a code owner August 19, 2025 11:23
@codecov

codecov Bot commented Aug 19, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.15668% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.88%. Comparing base (e91eb0b) to head (3012907).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6552      +/-   ##
==========================================
- Coverage   81.90%   81.88%   -0.02%     
==========================================
  Files         236      241       +5     
  Lines       75763    75715      -48     
==========================================
- Hits        62057    62003      -54     
- Misses      13706    13712       +6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hui-zhou-a Please delete the inserted init this is wrong.

Comment thread tests/system/extensions/test_configure_layout.py Outdated
@hui-zhou-a

hui-zhou-a commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

@hui-zhou-a Please delete the inserted init this is wrong.

@Samuelopez-ansys Which line of the code do you refer to?

@Samuelopez-ansys

Copy link
Copy Markdown
Member

@hui-zhou-a All these inits are wrong
image

Comment thread src/ansys/aedt/core/internal/filesystem.py
@hui-zhou-a
hui-zhou-a merged commit 1591c40 into main Aug 20, 2025
37 checks passed
@hui-zhou-a
hui-zhou-a deleted the refactor-configure-layout-2 branch August 20, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants