Skip to content

FIX: MATLAB script amp2db.m - #6559

Merged
scanta2 merged 7 commits into
mainfrom
fix/6558-MATLAB-amp2db
Sep 6, 2025
Merged

scanta2 merged 7 commits into
mainfrom
fix/6558-MATLAB-amp2db

Conversation

@tadanegishi

Copy link
Copy Markdown
Contributor

Description

Fix amp2db.m to convert dB scale data from linear scale data

Issue linked

#6558

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@tadanegishi
tadanegishi requested a review from a team as a code owner August 21, 2025 14:05
@tadanegishi tadanegishi added the bug Something isn't working label Aug 21, 2025

@gmalinve gmalinve left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tadanegishi,

You are modifying the wrong file.
PyAEDT source code has been moved to a different folder ansys/aedt/core and the file you want to modify is in the visualization/sbrplus folder.
Please also link your issue to this PR.

Thanks for taking care of this!

@codecov

codecov Bot commented Aug 21, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.01%. Comparing base (33061d0) to head (3d91c29).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6559   +/-   ##
=======================================
  Coverage   82.00%   82.01%           
=======================================
  Files         243      243           
  Lines       76278    76278           
=======================================
+ Hits        62553    62557    +4     
+ Misses      13725    13721    -4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys
Samuelopez-ansys marked this pull request as draft August 22, 2025 05:47
@tadanegishi
tadanegishi requested a review from scanta2 August 25, 2025 15:16
@scanta2

scanta2 commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

I am not sure about deleting all that folder unless we check with Bob

@Samuelopez-ansys

Copy link
Copy Markdown
Member

@scanta2 @tadanegishi Please check with Bob, because PyAEDT should not host non python files, some of them are already converted to python like the HDM class:

https://aedt.docs.pyansys.com/version/stable/API/visualization/advanced.html#heterogeneous-data-message

If you need to have these files in another public repo, we could think moving them to https://github.com/ansys/example-data

However, this is not ideal, as the code is written in MATLAB and has not been tested in any CI/CD pipeline, so it is not safe to have.

@tadanegishi

Copy link
Copy Markdown
Contributor Author

@Samuelopez-ansys I have asked Stefano and Bob to suggest good location for those MATLAB scripts. And, I have explained the situation as follow.

Some MATLAB scripts are currently duplicated or only located in pyaedt. For example, we have 3 copies of amp2db.m.

  • AEDT installation: ANSYS Inc\v252\AnsysEM\Delcross\Savant MATLAB
  • Deprecated folder: pyaedt\src\pyaedt\sbrplus\matlab
  • Official pyaedt folder: pyaedt\src\ansys\aedt\core\visualization\advanced\sbrplus\matlab

This PR is to delete MATLAB scripts in the Deprecated folder because we already have the same MATLAB scripts in the Official pyaedt folder. However, we don’t expect any MATLAB scripts in pyaedt and my suggestion is to migrate the MATLAB scripts to AEDT installation. Even if we decide to migrate the MATLAB scripts to AEDT installation in R26.1, we need to keep them in Official pyaedt folder for a while.

Thank you for suggesting new public repo, but I prefer to locate in AEDT installation. It would be important to locate the MATLAB scripts where users can find them easily.

@Samuelopez-ansys
Samuelopez-ansys marked this pull request as ready for review September 5, 2025 14:29
@Samuelopez-ansys

Copy link
Copy Markdown
Member

Thanks @tadanegishi, then in 2026R1, we will remove these Matlab scripts. Thank you for your inputs!

@scanta2
scanta2 enabled auto-merge (squash) September 5, 2025 14:54
@scanta2
scanta2 merged commit 3a33e69 into main Sep 6, 2025
@scanta2
scanta2 deleted the fix/6558-MATLAB-amp2db branch September 6, 2025 18:02
@gmalinve gmalinve linked an issue Sep 10, 2025 that may be closed by this pull request
2 tasks done
@gmalinve gmalinve mentioned this pull request Sep 10, 2025
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong calculation in amp2db.m

5 participants