Repository navigation
FIX: MATLAB script amp2db.m - #6559
Conversation
There was a problem hiding this comment.
Hi @tadanegishi,
You are modifying the wrong file.
PyAEDT source code has been moved to a different folder ansys/aedt/core and the file you want to modify is in the visualization/sbrplus folder.
Please also link your issue to this PR.
Thanks for taking care of this!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6559 +/- ##
=======================================
Coverage 82.00% 82.01%
=======================================
Files 243 243
Lines 76278 76278
=======================================
+ Hits 62553 62557 +4
+ Misses 13725 13721 -4 🚀 New features to boost your workflow:
|
|
I am not sure about deleting all that folder unless we check with Bob |
|
@scanta2 @tadanegishi Please check with Bob, because PyAEDT should not host non python files, some of them are already converted to python like the HDM class: If you need to have these files in another public repo, we could think moving them to https://github.com/ansys/example-data However, this is not ideal, as the code is written in MATLAB and has not been tested in any CI/CD pipeline, so it is not safe to have. |
|
@Samuelopez-ansys I have asked Stefano and Bob to suggest good location for those MATLAB scripts. And, I have explained the situation as follow. Some MATLAB scripts are currently duplicated or only located in pyaedt. For example, we have 3 copies of amp2db.m.
This PR is to delete MATLAB scripts in the Deprecated folder because we already have the same MATLAB scripts in the Official pyaedt folder. However, we don’t expect any MATLAB scripts in pyaedt and my suggestion is to migrate the MATLAB scripts to AEDT installation. Even if we decide to migrate the MATLAB scripts to AEDT installation in R26.1, we need to keep them in Official pyaedt folder for a while. Thank you for suggesting new public repo, but I prefer to locate in AEDT installation. It would be important to locate the MATLAB scripts where users can find them easily. |
|
Thanks @tadanegishi, then in 2026R1, we will remove these Matlab scripts. Thank you for your inputs! |
Description
Fix amp2db.m to convert dB scale data from linear scale data
Issue linked
#6558
Checklist