FIX: Issue with circuit extensions - #6563
Conversation
fd3b068
|
@Samuelopez-ansys I had to perform some changes in your code because one test was failing with an open window (which blocked the CI). Some changes are undoing some of the changes you were performing but were required to follow the logic on pining an extension under the correct type of toolkit. We can discuss about that later so that I can clarify my point. Please have a look at fd3b068 |
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Marking as requested changes to ensure that my comment is carefully checked. I had to perform some changes to fix the CI and logic of the proposed changes. This might be countering a part of what you wanted to do.
|
@SMoraisAnsys, I reverted your fixes, and I fixed the Unit test. I think it now works as expected. Please @eblanco-ansys could you test it? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6563 +/- ##
==========================================
+ Coverage 80.02% 81.93% +1.91%
==========================================
Files 242 242
Lines 75950 75950
==========================================
+ Hits 60777 62230 +1453
+ Misses 15173 13720 -1453 🚀 New features to boost your workflow:
|
Description
Circuit and HFSS 3DLayout extension were not correctly launched.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist