Skip to content

FIX: Issue with circuit extensions - #6563

Merged
Samuelopez-ansys merged 12 commits into
mainfrom
fix/issue_circuit_extensions
Sep 1, 2025
Merged

Samuelopez-ansys merged 12 commits into
mainfrom
fix/issue_circuit_extensions

Conversation

@Samuelopez-ansys

@Samuelopez-ansys Samuelopez-ansys commented Aug 22, 2025 •

Copy link
Copy Markdown
Member

Description

Circuit and HFSS 3DLayout extension were not correctly launched.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys
Samuelopez-ansys requested a review from a team as a code owner August 22, 2025 06:49
@github-actions github-actions Bot added the bug Something isn't working label Aug 22, 2025
maxcapodi78
maxcapodi78 previously approved these changes Aug 22, 2025

@maxcapodi78 maxcapodi78 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys
Samuelopez-ansys enabled auto-merge (squash) August 22, 2025 11:36
SMoraisAnsys
SMoraisAnsys previously approved these changes Aug 25, 2025
@SMoraisAnsys
SMoraisAnsys dismissed stale reviews from maxcapodi78 and themself via fd3b068 August 28, 2025 08:00
@SMoraisAnsys

Copy link
Copy Markdown
Collaborator

@Samuelopez-ansys I had to perform some changes in your code because one test was failing with an open window (which blocked the CI). Some changes are undoing some of the changes you were performing but were required to follow the logic on pining an extension under the correct type of toolkit. We can discuss about that later so that I can clarify my point. Please have a look at fd3b068

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as requested changes to ensure that my comment is carefully checked. I had to perform some changes to fix the CI and logic of the proposed changes. This might be countering a part of what you wanted to do.

@Samuelopez-ansys

Copy link
Copy Markdown
Member Author

@SMoraisAnsys, I reverted your fixes, and I fixed the Unit test. I think it now works as expected.

Please @eblanco-ansys could you test it?

@codecov

codecov Bot commented Sep 1, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.93%. Comparing base (c5f471f) to head (54132c2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6563      +/-   ##
==========================================
+ Coverage   80.02%   81.93%   +1.91%     
==========================================
  Files         242      242              
  Lines       75950    75950              
==========================================
+ Hits        60777    62230    +1453     
+ Misses      15173    13720    -1453     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys
Samuelopez-ansys merged commit c13d411 into main Sep 1, 2025
66 of 67 checks passed
@Samuelopez-ansys
Samuelopez-ansys deleted the fix/issue_circuit_extensions branch September 1, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants