Skip to content

CHORE: Enforce simple ruff "flake8-todos" TD rules - #6570

Merged
SMoraisAnsys merged 9 commits into
mainfrom
chore/enforce-simple-ruff-flake8-todos-rules
Aug 29, 2025
Merged

CHORE: Enforce simple ruff "flake8-todos" TD rules#6570
SMoraisAnsys merged 9 commits into
mainfrom
chore/enforce-simple-ruff-flake8-todos-rules

Conversation

@ecoussoux-ansys

Copy link
Copy Markdown
Contributor

Description

This PR introduces fixes mandated by ruff for the following 4 "flake8-todos" TD rules:

  • TD001 (invalid-todo-tag),
  • TD004 (missing-todo-colon),
  • TD005 (missing-todo-description),
  • TD006 (invalid-todo-capitalization).

For more details on these rules, please refer to https://docs.astral.sh/ruff/rules/#flake8-todos-td

The changes to the modified files are absolutely minimal (related to the formatting of "TODO"s), but will allow the rules specified above to be removed from the list of ignored linting rules for ruff in the pyproject.toml file.

The version of the ruff pre-commit hook in the .pre-commit-config.yaml file is updated to the latest release.

As for the previous ruff-related PRs, this effort is part of the migration of pyaedt towards using ruff for code formatting and linting, as requested in issue #4775.
This PR is also contributing to the efforts described in issue #5504.

Issue linked

Related to #4775 and #5504.

@ecoussoux-ansys ecoussoux-ansys self-assigned this Aug 25, 2025
@ecoussoux-ansys
ecoussoux-ansys requested a review from a team as a code owner August 25, 2025 12:02
@ecoussoux-ansys ecoussoux-ansys added the maintenance Package and maintenance related label Aug 25, 2025
@codecov

codecov Bot commented Aug 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.93%. Comparing base (fcb761a) to head (82f625c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6570   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files         242      242           
  Lines       75950    75950           
=======================================
  Hits        62226    62226           
  Misses      13724    13724           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys
SMoraisAnsys enabled auto-merge (squash) August 28, 2025 07:12
@SMoraisAnsys
SMoraisAnsys merged commit 44130fe into main Aug 29, 2025
38 checks passed
@SMoraisAnsys
SMoraisAnsys deleted the chore/enforce-simple-ruff-flake8-todos-rules branch August 29, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants