FIX: 3dlayout component coordinate - #6574
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6574 +/- ##
==========================================
+ Coverage 80.39% 81.89% +1.49%
==========================================
Files 241 241
Lines 75742 75748 +6
==========================================
+ Hits 60890 62031 +1141
+ Misses 14852 13717 -1135 🚀 New features to boost your workflow:
|
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Seems like this is not the only place where components.instances.keys() is used. Could you also update the coordinate systems for those cases if it makes sense ?
Also can you extend the description of your PR ? Without an explanation on why those changes are required, it's a bit complicated to follow the need.
@SMoraisAnsys Done |
This PR fixes the bug coordinates from 3dlayout component are not imported.
The name of the coordinates from 3dl component is wrong
currently named as f"{comp_name}"
Should be named as f"{comp_name}_{pin_name}