Skip to content

FIX: 3dlayout component coordinate - #6574

Merged
SMoraisAnsys merged 4 commits into
mainfrom
fix-3dlcomp-coordinate
Aug 27, 2025
Merged

FIX: 3dlayout component coordinate#6574
SMoraisAnsys merged 4 commits into
mainfrom
fix-3dlcomp-coordinate

Conversation

@hui-zhou-a

@hui-zhou-a hui-zhou-a commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

This PR fixes the bug coordinates from 3dlayout component are not imported.

The name of the coordinates from 3dl component is wrong
currently named as f"{comp_name}"
Should be named as f"{comp_name}_{pin_name}

@hui-zhou-a
hui-zhou-a requested a review from a team as a code owner August 26, 2025 13:52
@github-actions github-actions Bot added the bug Something isn't working label Aug 26, 2025
@codecov

codecov Bot commented Aug 26, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.89%. Comparing base (5de5791) to head (b8b90da).
⚠️ Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6574      +/-   ##
==========================================
+ Coverage   80.39%   81.89%   +1.49%     
==========================================
  Files         241      241              
  Lines       75742    75748       +6     
==========================================
+ Hits        60890    62031    +1141     
+ Misses      14852    13717    -1135     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is not the only place where components.instances.keys() is used. Could you also update the coordinate systems for those cases if it makes sense ?

Also can you extend the description of your PR ? Without an explanation on why those changes are required, it's a bit complicated to follow the need.

@hui-zhou-a

Copy link
Copy Markdown
Contributor Author

Seems like this is not the only place where components.instances.keys() is used. Could you also update the coordinate systems for those cases if it makes sense ?

Also can you extend the description of your PR ? Without an explanation on why those changes are required, it's a bit complicated to follow the need.

@SMoraisAnsys Done

@SMoraisAnsys
SMoraisAnsys merged commit f68b401 into main Aug 27, 2025
36 of 37 checks passed
@SMoraisAnsys
SMoraisAnsys deleted the fix-3dlcomp-coordinate branch August 27, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants