Skip to content

REFACTOR: insert layout component - #6580

Merged
maxcapodi78 merged 9 commits into
mainfrom
refactor-insert-layout-component
Aug 29, 2025
Merged

maxcapodi78 merged 9 commits into
mainfrom
refactor-insert-layout-component

Conversation

@hui-zhou-a

Copy link
Copy Markdown
Contributor

Below two methods are implemented to cover more user scenarios

  • new method add_layout_component_definition
  • new method _insert_layout_component_instance

This implementation allows

  • give name to 3d layout component definition
  • insert layout component by providing definition name
  • user provided parameter mapping

@hui-zhou-a
hui-zhou-a requested a review from a team as a code owner August 28, 2025 05:10
@codecov

codecov Bot commented Aug 28, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.90%. Comparing base (687c40b) to head (e346498).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6580      +/-   ##
==========================================
+ Coverage   81.89%   81.90%   +0.01%     
==========================================
  Files         241      241              
  Lines       75748    75792      +44     
==========================================
+ Hits        62031    62079      +48     
+ Misses      13717    13713       -4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maxcapodi78 maxcapodi78 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78
maxcapodi78 merged commit fcb761a into main Aug 29, 2025
37 checks passed
@maxcapodi78
maxcapodi78 deleted the refactor-insert-layout-component branch August 29, 2025 06:51
@hui-zhou-a hui-zhou-a linked an issue Oct 6, 2025 that may be closed by this pull request
2 tasks done
@hui-zhou-a hui-zhou-a mentioned this pull request Oct 15, 2025
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in insert_layout_component

3 participants