Skip to content

FEAT: Add Profile class - #6593

Merged
Devin-Crawford merged 90 commits into
mainfrom
feat/6290_add_profile_class
Sep 23, 2025
Merged

FEAT: Add Profile class#6593
Devin-Crawford merged 90 commits into
mainfrom
feat/6290_add_profile_class

Conversation

@Devin-Crawford

Copy link
Copy Markdown
Contributor

Description

Add the Profile class and framework to simplify parsing and viewing solver profiles.

  • Add unit tests for HFSS, HFSS 3D Layout, Maxwell 2D and Maxwell 3D transient + Icepak.

Issue linked

#6290
#6523
#6481

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

Devin and others added 30 commits June 18, 2025 11:53
Resolve issue 6278. Allow a list to be passed
for the "Frequency" argument and automatically apply the multi-frequency adapt setup.
- Profile
- Variation
Use the project name to save the new project after it is extracted from an archive.
Create a Profiles class, call it from setup.get_profile(). The actual profile for a single simulation is an instance of SimulationProfile.
Basic class is working.
- When an archive file is extracted, the
  project file stem name will be incremented
  by an integer if the project file already
  exists.
…rofile_class

# Conflicts:
#	src/ansys/aedt/core/application/design.py
- Simplify syntax.
…oject' into fix/6400-use-archive-name-for-project
…rofile_class

# Conflicts:
#	src/ansys/aedt/core/application/design.py
- Simplify syntax.
- Simplify syntax.
- Add classes and methods to simplify handling of simulation profile data.
- Support for:
  - HFSS Adaptive passes and frequency sweep.
  - HFSS 3D Layout
  - Maxwell eddy
    - steady-state
    - transient
  - Icepak
    - transient
    - steady-state
- Fix minor bugs.
- Add pyaedt_function_handler()
- Add unit tests for Profile class.
- General cleanup
- Add table method to ProfileStep
…_class

# Conflicts:
#	src/ansys/aedt/core/application/design.py
#	tests/system/solvers/test_00_analyze.py
- Refactor unit tests to use "yield" for applicaiton isntances.
- Update with differences from main branch.
- Include changes to archive recovrey in fix/6400-archive
@Samuelopez-ansys

Copy link
Copy Markdown
Member

@Devin-Crawford I have added a new documentation section for this new file, but please consider to improve it because it needs more information and a few examples. It is important, because it is how the AI can learn.

Devin and others added 3 commits September 11, 2025 18:58
- Retrieve aedt archive files from the pyaedt repo.
# Conflicts:
#	tests/system/solvers/test_00_analyze.py
@Samuelopez-ansys

Samuelopez-ansys commented Sep 12, 2025

Copy link
Copy Markdown
Member

@Devin-Crawford

Now all tests are passing, but it is still downloading the files.
Now do you think all tests are passing. We can improve it in the next PR, Let me know how you prefer to proceed.

@Samuelopez-ansys
Samuelopez-ansys marked this pull request as draft September 12, 2025 09:16
auto-merge was automatically disabled September 12, 2025 09:16

Pull request was converted to draft

Devin and others added 3 commits September 19, 2025 16:23
- Retrieve aedt archive files from the pyaedt repo.
- Minor updates to handle Icepak profile.
@Devin-Crawford

Copy link
Copy Markdown
Contributor Author

@Devin-Crawford

Now all tests are passing, but it is still downloading the files. Now do you think all tests are passing. We can improve it in the next PR, Let me know how you prefer to proceed.

Now only examples from the local repo are being used.

@Devin-Crawford

Copy link
Copy Markdown
Contributor Author

@Devin-Crawford I have added a new documentation section for this new file, but please consider to improve it because it needs more information and a few examples. It is important, because it is how the AI can learn.

I will update the doc next.

@Devin-Crawford
Devin-Crawford marked this pull request as ready for review September 23, 2025 01:18
@Devin-Crawford
Devin-Crawford enabled auto-merge (squash) September 23, 2025 01:19
@Devin-Crawford

Copy link
Copy Markdown
Contributor Author

@Devin-Crawford I have added a new documentation section for this new file, but please consider to improve it because it needs more information and a few examples. It is important, because it is how the AI can learn.

I will update the doc next.

Done.

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Devin-Crawford This is really great. I like how it is implemented, and I think it is really useful!

@Devin-Crawford
Devin-Crawford merged commit d8fadd9 into main Sep 23, 2025
38 checks passed
@Devin-Crawford
Devin-Crawford deleted the feat/6290_add_profile_class branch September 23, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants