Skip to content

FIX: Some minor updates to PyAedt - #6621

Merged
Samuelopez-ansys merged 26 commits into
mainfrom
B1329277
Sep 12, 2025
Merged

Samuelopez-ansys merged 26 commits into
mainfrom
B1329277

Conversation

@jsalant22

Copy link
Copy Markdown
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@jsalant22
jsalant22 requested a review from a team as a code owner September 8, 2025 14:51
@jsalant22 jsalant22 changed the title Some minor updates to PyAedt FIX/Some minor updates to PyAedt Sep 8, 2025
@jsalant22 jsalant22 changed the title FIX/Some minor updates to PyAedt FIX: Some minor updates to PyAedt Sep 8, 2025
@codecov

codecov Bot commented Sep 8, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.37795% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.33%. Comparing base (04009a1) to head (4e86c8b).
⚠️ Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (76.37%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6621      +/-   ##
==========================================
+ Coverage   82.26%   82.33%   +0.07%     
==========================================
  Files         243      242       -1     
  Lines       76759    76847      +88     
==========================================
+ Hits        63144    63274     +130     
+ Misses      13615    13573      -42     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsalant22
jsalant22 marked this pull request as draft September 8, 2025 18:49
@jsalant22
jsalant22 marked this pull request as ready for review September 10, 2025 15:25
@Samuelopez-ansys
Samuelopez-ansys enabled auto-merge (squash) September 10, 2025 22:09
@Samuelopez-ansys

Copy link
Copy Markdown
Member

Hi @jsalant22 , with your changes, some unit tests are failing, please could you review them? Thanks

@Samuelopez-ansys

Copy link
Copy Markdown
Member

Hi @jsalant22 , the coverage is not reaching the minimum, is it possible to improve? If not, I will merge this PR, but at some point, we need to increase the coverage of the full repo, we are working on that actively.

@Samuelopez-ansys
Samuelopez-ansys merged commit 0e281d2 into main Sep 12, 2025
38 of 39 checks passed
@Samuelopez-ansys
Samuelopez-ansys deleted the B1329277 branch September 12, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants