Repository navigation
FIX: Some minor updates to PyAedt - #6621
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (76.37%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6621 +/- ##
==========================================
+ Coverage 82.26% 82.33% +0.07%
==========================================
Files 243 242 -1
Lines 76759 76847 +88
==========================================
+ Hits 63144 63274 +130
+ Misses 13615 13573 -42 🚀 New features to boost your workflow:
|
fix some minor discrepancies between auto-code generator and pre-commit
jsalant22
marked this pull request as draft
September 8, 2025 18:49
also fix the Emit Frequency units
jsalant22
marked this pull request as ready for review
September 10, 2025 15:25
Samuelopez-ansys
previously approved these changes
Sep 10, 2025
Samuelopez-ansys
enabled auto-merge (squash)
September 10, 2025 22:09
Member
|
Hi @jsalant22 , with your changes, some unit tests are failing, please could you review them? Thanks |
Member
|
Hi @jsalant22 , the coverage is not reaching the minimum, is it possible to improve? If not, I will merge this PR, but at some point, we need to increase the coverage of the full repo, we are working on that actively. |
Samuelopez-ansys
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist