Skip to content

FIX: moved fpdf2 and rpyc in optional dependencies - #6647

Merged
Samuelopez-ansys merged 5 commits into
mainfrom
change_pyaedt_requirements
Sep 16, 2025
Merged

Samuelopez-ansys merged 5 commits into
mainfrom
change_pyaedt_requirements

Conversation

@maxcapodi78

Copy link
Copy Markdown
Member

Description

fpdf2 and rpyc are two packages that are used only in a specific class of pyaedt.
Moved them to optional

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@maxcapodi78
maxcapodi78 requested a review from a team as a code owner September 15, 2025 09:51
@github-actions github-actions Bot added the maintenance Package and maintenance related label Sep 15, 2025
SMoraisAnsys
SMoraisAnsys previously approved these changes Sep 15, 2025

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Sep 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.34%. Comparing base (92ca3f8) to head (ebce376).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6647   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files         242      242           
  Lines       76995    76995           
=======================================
+ Hits        63402    63404    +2     
+ Misses      13593    13591    -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys
Samuelopez-ansys merged commit 0a3d352 into main Sep 16, 2025
39 checks passed
@Samuelopez-ansys
Samuelopez-ansys deleted the change_pyaedt_requirements branch September 16, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants