FIX: Fix issue 6719 get_string_version - #6722
Merged
Merged
Conversation
- renamed get_string_version to normalize_version_to_string
- moved tests from system test test_01_general_methods.py to unit\test_general_methods.py
Alberto-DM
enabled auto-merge (squash)
October 1, 2025 21:13
…n' into fix-issue-6719-get_string_version
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6722 +/- ##
===========================================
+ Coverage 28.07% 83.16% +55.09%
===========================================
Files 245 245
Lines 77393 77404 +11
===========================================
+ Hits 21729 64376 +42647
+ Misses 55664 13028 -42636 🚀 New features to boost your workflow:
|
Samuelopez-ansys
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the function
get_string_versionto be more robust and accept more input formats.The old version would let pass random strings.
Added also extensive unit tests.
Finally, I separated the methods to check and normalize the user input from the internal check of the version format.
Issue linked
fix issue #6719