Skip to content

FIX: Fix issue 6719 get_string_version - #6722

Merged
Alberto-DM merged 10 commits into
mainfrom
fix-issue-6719-get_string_version
Oct 3, 2025
Merged

FIX: Fix issue 6719 get_string_version#6722
Alberto-DM merged 10 commits into
mainfrom
fix-issue-6719-get_string_version

Conversation

@Alberto-DM

@Alberto-DM Alberto-DM commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Description

Changed the function get_string_version to be more robust and accept more input formats.
The old version would let pass random strings.
Added also extensive unit tests.
Finally, I separated the methods to check and normalize the user input from the internal check of the version format.

Issue linked

fix issue #6719

- renamed get_string_version to normalize_version_to_string
- moved tests from system test test_01_general_methods.py to unit\test_general_methods.py
@Alberto-DM
Alberto-DM requested a review from a team as a code owner October 1, 2025 16:25
@Alberto-DM Alberto-DM linked an issue Oct 1, 2025 that may be closed by this pull request
@github-actions github-actions Bot added the bug Something isn't working label Oct 1, 2025
@Alberto-DM
Alberto-DM enabled auto-merge (squash) October 1, 2025 21:13
@codecov

codecov Bot commented Oct 2, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.16%. Comparing base (038b1c0) to head (6100853).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6722       +/-   ##
===========================================
+ Coverage   28.07%   83.16%   +55.09%     
===========================================
  Files         245      245               
  Lines       77393    77404       +11     
===========================================
+ Hits        21729    64376    +42647     
+ Misses      55664    13028    -42636     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alberto-DM
Alberto-DM merged commit d187948 into main Oct 3, 2025
71 of 73 checks passed
@Alberto-DM
Alberto-DM deleted the fix-issue-6719-get_string_version branch October 3, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve get_string_version function

3 participants