Skip to content

FEAT: Enhance custom extension dialog with display name and validation checks - #6760

Merged
eblanco-ansys merged 13 commits into
mainfrom
feat/add-custom-extension-check-already-exists
Oct 13, 2025
Merged

eblanco-ansys merged 13 commits into
mainfrom
feat/add-custom-extension-check-already-exists

Conversation

@eblanco-ansys

Copy link
Copy Markdown
Contributor

Description

Improve the custom extension dialog by adding a display name field and implementing validation checks to ensure unique and valid names for extensions.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@eblanco-ansys
eblanco-ansys requested a review from a team as a code owner October 13, 2025 12:42
@eblanco-ansys
eblanco-ansys enabled auto-merge (squash) October 13, 2025 12:42
@eblanco-ansys eblanco-ansys changed the title Enhance custom extension dialog with display name and validation checks FEAT: Enhance custom extension dialog with display name and validation checks Oct 13, 2025
@github-actions github-actions Bot added the enhancement New features or code improvements label Oct 13, 2025
@codecov

codecov Bot commented Oct 13, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.21%. Comparing base (68c31d2) to head (c6d24d7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6760      +/-   ##
==========================================
+ Coverage   83.16%   83.21%   +0.05%     
==========================================
  Files         246      246              
  Lines       77493    77458      -35     
==========================================
+ Hits        64444    64457      +13     
+ Misses      13049    13001      -48     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gmalinve
gmalinve previously approved these changes Oct 13, 2025
SMoraisAnsys
SMoraisAnsys previously approved these changes Oct 13, 2025

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left minor comments

Comment thread src/ansys/aedt/core/extensions/installer/extension_manager.py Outdated
Comment thread src/ansys/aedt/core/extensions/installer/extension_manager.py Outdated
Comment thread src/ansys/aedt/core/extensions/installer/extension_manager.py Outdated
Comment thread src/ansys/aedt/core/extensions/installer/extension_manager.py Outdated
Comment thread src/ansys/aedt/core/extensions/installer/extension_manager.py Outdated
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@eblanco-ansys
eblanco-ansys dismissed stale reviews from SMoraisAnsys and gmalinve via 499f25b October 13, 2025 15:50
eblanco-ansys and others added 4 commits October 13, 2025 17:50
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@eblanco-ansys
eblanco-ansys merged commit 7a218b9 into main Oct 13, 2025
38 checks passed
@eblanco-ansys
eblanco-ansys deleted the feat/add-custom-extension-check-already-exists branch October 13, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants