Skip to content

FIX: EMIT Pyaedt fixes - #6768

Merged
jsalant22 merged 42 commits into
mainfrom
B1342786
Oct 29, 2025
Merged

jsalant22 merged 42 commits into
mainfrom
B1342786

Conversation

@jsalant22

@jsalant22 jsalant22 commented Oct 14, 2025 •

Copy link
Copy Markdown
Contributor

Fix data rate conversion: B1347519

Fix some issues with creating components: B1347443

Make sure Emitters and Waveforms are cast correctly before returning: B1347518

Remove some unused node types (CategoriesViewNode and TopLevelSimulation): B1345240

Make sure _set_table_data() and _get_table_data() can handle both NodeProp and ColumnData tables (and both for BB EmissionsNodes); also fix some table_data() docstrings: B1342786

Exclude parameters used to orient components from the node classes: B1343826

Fix conversion from yards to meters and add conversion from mile to meters: B1347453

Add some unit tests

Allow users to specify parameters as unitless strings (in addition to unitless floats and strings with units): B1347439

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

Fix data rate conversion: B1347519

Fix some issues with creating components: B1347443

Make sure Emitters and Waveforms are cast correctly before returning: B1347518

Remove some unused node types (CategoriesViewNode and TopLevelSimulation): B1345240

Make sure _set_table_data() and _get_table_data() can handle both NodeProp and ColumnData tables (and both for BB EmissionsNodes); also fix some table_data() docstrings: B1342786

Exclude parameters used to orient components from the node classes: B1343826

Fix conversion from yards to meters and add conversion from mile to meters: B1347453

Add some unit tests

Allow users to specify parameters as unitless strings (in addition to unitless floats and strings with units): B1347439
@jsalant22
jsalant22 requested a review from a team as a code owner October 14, 2025 19:35
@codecov

codecov Bot commented Oct 14, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.52941% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.47%. Comparing base (26cd128) to head (a764290).
⚠️ Report is 3 commits behind head on main.

❌ Your patch status has failed because the patch coverage (83.52%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6768      +/-   ##
==========================================
+ Coverage   83.30%   83.47%   +0.16%     
==========================================
  Files         246      245       -1     
  Lines       77438    77482      +44     
==========================================
+ Hits        64512    64679     +167     
+ Misses      12926    12803     -123     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsalant22

Copy link
Copy Markdown
Contributor Author

@ramin4667 Can you do a code review on this branch? Thanks

@github-actions github-actions Bot added the maintenance Package and maintenance related label Oct 15, 2025
anspraksaph
anspraksaph previously approved these changes Oct 17, 2025

@anspraksaph anspraksaph left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change resolve all issues mentioned in the description.

ramin4667
ramin4667 previously approved these changes Oct 20, 2025
@jsalant22

Copy link
Copy Markdown
Contributor Author

@ansys/pyaedt-maintainers This is ready for your review. Thanks!

@jsalant22

Copy link
Copy Markdown
Contributor Author

@ansys/pyaedt-maintainers Can we get this merged?

@jsalant22

Copy link
Copy Markdown
Contributor Author

@Samuelopez-ansys @SMoraisAnsys Can we get this merged?

@gmalinve

Copy link
Copy Markdown
Contributor

@jsalant22 I just merged the latest main into this but codecov was failing.

Alberto-DM
Alberto-DM previously approved these changes Oct 23, 2025

@Alberto-DM Alberto-DM left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing constants.py.

@SMoraisAnsys SMoraisAnsys left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the current failure is associated to a flaky test. I'll add it to the pool of flaky_linux tests.
@jsalant22 Could you please extend the coverage of your changes ? Seems like codecov reports a lot of missed lines and this would impact PyAEDT's code coverage if merged as it is.

@SMoraisAnsys

Copy link
Copy Markdown
Collaborator

@jsalant22 We can rerun the flaky test if that's the only thing that is failing so no worries on that, I'll review the code and we'll be able to merge the changes if everything is fine. Thanks for your work !

SMoraisAnsys
SMoraisAnsys previously approved these changes Oct 27, 2025

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, thanks again for your hard work @jsalant22

Comment thread src/ansys/aedt/core/emit_core/nodes/emit_node.py
@jsalant22

Copy link
Copy Markdown
Contributor Author

@SMoraisAnsys Anything else on this?

@jsalant22
jsalant22 merged commit 5a28b0a into main Oct 29, 2025
100 of 103 checks passed
@jsalant22
jsalant22 deleted the B1342786 branch October 29, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants