Skip to content

FIX: 6744-Update analysis.py - #6770

Merged
Samuelopez-ansys merged 18 commits into
mainfrom
fix/6744_touchstone_export
Jan 12, 2026
Merged

Samuelopez-ansys merged 18 commits into
mainfrom
fix/6744_touchstone_export

Conversation

@Devin-Crawford

@Devin-Crawford Devin-Crawford commented Oct 15, 2025 •

Copy link
Copy Markdown
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

- Refactor AvailableMethods class
  - add nominal_variation() method
  - deprecate get_independent_nominal_values()
  - update Analysis._export_touchstone() (fix #6744)
@Devin-Crawford Devin-Crawford changed the title Update analysis.py FIX: 6744-Update analysis.py Oct 15, 2025
@github-actions github-actions Bot added the bug Something isn't working label Oct 15, 2025
@codecov

codecov Bot commented Oct 15, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.83%. Comparing base (88b878b) to head (2cceef6).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6770       +/-   ##
===========================================
+ Coverage   46.79%   80.83%   +34.04%     
===========================================
  Files         254      254               
  Lines       77348    77352        +4     
===========================================
+ Hits        36194    62529    +26335     
+ Misses      41154    14823    -26331     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gmalinve gmalinve removed their assignment Oct 19, 2025
@Devin-Crawford
Devin-Crawford marked this pull request as ready for review October 23, 2025 11:52
@Devin-Crawford
Devin-Crawford requested a review from a team as a code owner October 23, 2025 11:52
@Devin-Crawford
Devin-Crawford enabled auto-merge (squash) October 23, 2025 11:53
- Also update unit tests.
@Devin-Crawford
Devin-Crawford marked this pull request as draft October 24, 2025 12:59
auto-merge was automatically disabled October 24, 2025 12:59

Pull request was converted to draft

@github-actions github-actions Bot added the testing Anything related to testing label Oct 24, 2025
@Devin-Crawford
Devin-Crawford marked this pull request as ready for review October 25, 2025 10:51
@Devin-Crawford
Devin-Crawford enabled auto-merge (squash) October 27, 2025 07:06
@Devin-Crawford

Copy link
Copy Markdown
Contributor Author

@maxcapodi78 , @SMoraisAnsys : This is ready.

@Samuelopez-ansys
Samuelopez-ansys marked this pull request as draft January 9, 2026 09:57
auto-merge was automatically disabled January 9, 2026 09:57

Pull request was converted to draft

@Samuelopez-ansys
Samuelopez-ansys marked this pull request as ready for review January 9, 2026 09:58
@Samuelopez-ansys
Samuelopez-ansys merged commit 05d2e2b into main Jan 12, 2026
43 checks passed
@Samuelopez-ansys
Samuelopez-ansys deleted the fix/6744_touchstone_export branch January 12, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem in exporting touchstone file with PyAEDT - Optimetrics - HFSS

4 participants