Skip to content

FIX: Small change to port naming when no names are provided to align with Circuit behaviour - #6816

Merged
maxcapodi78 merged 2 commits into
mainfrom
fix_touchstone_data
Oct 27, 2025
Merged

maxcapodi78 merged 2 commits into
mainfrom
fix_touchstone_data

Conversation

@maxcapodi78

Copy link
Copy Markdown
Member

Small change to port naming when no names are provided to align with Circuit behaviour

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@maxcapodi78
maxcapodi78 requested a review from gmalinve October 24, 2025 15:21
@maxcapodi78
maxcapodi78 requested a review from a team as a code owner October 24, 2025 15:21
@maxcapodi78
maxcapodi78 enabled auto-merge (squash) October 24, 2025 15:21
@github-actions github-actions Bot added the bug Something isn't working label Oct 24, 2025
@codecov

codecov Bot commented Oct 24, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.31%. Comparing base (25341ee) to head (aedd07a).
⚠️ Report is 3 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6816   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         246      246           
  Lines       77423    77423           
=======================================
+ Hits        64507    64508    +1     
+ Misses      12916    12915    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maxcapodi78
maxcapodi78 merged commit d7335c0 into main Oct 27, 2025
1 check passed
@maxcapodi78
maxcapodi78 deleted the fix_touchstone_data branch October 27, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants