Skip to content

feat: allow for product_version on geometry service launcher function#1182

Merged
RobPasMue merged 6 commits into
mainfrom
feat/expose-product_version-gs
Apr 30, 2024
Merged

feat: allow for product_version on geometry service launcher function#1182
RobPasMue merged 6 commits into
mainfrom
feat/expose-product_version-gs

Conversation

@RobPasMue

Copy link
Copy Markdown
Member

Description

Allow the usage of product version on the Geometry Service launcher functions.

Issue linked

Closes #1181

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Apr 30, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner April 30, 2024 09:41
@RobPasMue RobPasMue linked an issue Apr 30, 2024 that may be closed by this pull request
@github-actions github-actions Bot added the enhancement New features or code improvements label Apr 30, 2024
Comment thread src/ansys/geometry/core/connection/launcher.py Outdated
@RobPasMue RobPasMue merged commit c807809 into main Apr 30, 2024
@RobPasMue RobPasMue deleted the feat/expose-product_version-gs branch April 30, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose product_version for geometry service launcher

2 participants