feat: add new arc constructors#1208
Merged
Merged
Conversation
Member
Author
|
Missing tests and examples on documentation |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
==========================================
+ Coverage 90.59% 90.67% +0.08%
==========================================
Files 93 94 +1
Lines 7015 7078 +63
==========================================
+ Hits 6355 6418 +63
Misses 660 660 ☔ View full report in Codecov by Sentry. |
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
PipKat
reviewed
May 22, 2024
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Member
Author
|
@PipKat - would you mind doing a final review? 😄 |
PipKat
reviewed
May 23, 2024
PipKat
reviewed
May 23, 2024
PipKat
reviewed
May 23, 2024
PipKat
reviewed
May 23, 2024
PipKat
reviewed
May 23, 2024
PipKat
reviewed
May 23, 2024
PipKat
reviewed
May 23, 2024
Member
Author
|
Thank you as always @PipKat - really appreciated! Let me get your feedback in. |
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addressing issues #1207 and #1206
Issue linked
Closes #1207 and #1206
Checklist
feat: extrude circle to cylinder)