Skip to content

feat: add new arc constructors#1208

Merged
RobPasMue merged 12 commits into
mainfrom
feat/arc-ctors
May 23, 2024
Merged

feat: add new arc constructors#1208
RobPasMue merged 12 commits into
mainfrom
feat/arc-ctors

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue commented May 22, 2024

Description

Addressing issues #1207 and #1206

Issue linked

Closes #1207 and #1206

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this May 22, 2024
@RobPasMue
Copy link
Copy Markdown
Member Author

Missing tests and examples on documentation

@RobPasMue RobPasMue linked an issue May 22, 2024 that may be closed by this pull request
@github-actions github-actions Bot added the enhancement New features or code improvements label May 22, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (7a4762a) to head (225fa87).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
+ Coverage   90.59%   90.67%   +0.08%     
==========================================
  Files          93       94       +1     
  Lines        7015     7078      +63     
==========================================
+ Hits         6355     6418      +63     
  Misses        660      660              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/ansys/geometry/core/math/misc.py Outdated
Comment thread src/ansys/geometry/core/math/misc.py Outdated
Comment thread src/ansys/geometry/core/math/misc.py Outdated
Comment thread src/ansys/geometry/core/math/misc.py Outdated
Comment thread src/ansys/geometry/core/math/misc.py Outdated
Comment thread src/ansys/geometry/core/math/misc.py Outdated
Comment thread src/ansys/geometry/core/sketch/arc.py Outdated
Comment thread src/ansys/geometry/core/sketch/arc.py Outdated
Comment thread src/ansys/geometry/core/sketch/arc.py Outdated
Comment thread src/ansys/geometry/core/sketch/arc.py Outdated
Comment thread src/ansys/geometry/core/sketch/arc.py Outdated
Comment thread src/ansys/geometry/core/sketch/arc.py Outdated
Comment thread src/ansys/geometry/core/sketch/sketch.py
RobPasMue and others added 4 commits May 23, 2024 08:33
@github-actions github-actions Bot added the testing Anything related to tests label May 23, 2024
@RobPasMue RobPasMue marked this pull request as ready for review May 23, 2024 10:52
@RobPasMue RobPasMue requested a review from a team as a code owner May 23, 2024 10:52
@RobPasMue
Copy link
Copy Markdown
Member Author

@PipKat - would you mind doing a final review? 😄

@RobPasMue RobPasMue requested a review from PipKat May 23, 2024 12:17
Comment thread src/ansys/geometry/core/math/misc.py Outdated
Comment thread src/ansys/geometry/core/sketch/arc.py Outdated
Comment thread src/ansys/geometry/core/sketch/arc.py Outdated
Comment thread src/ansys/geometry/core/sketch/sketch.py Outdated
Comment thread src/ansys/geometry/core/sketch/sketch.py Outdated
Comment thread tests/test_sketch.py Outdated
Comment thread tests/test_sketch.py Outdated
PipKat
PipKat previously approved these changes May 23, 2024
Copy link
Copy Markdown
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very, very minor suggestions.

@RobPasMue
Copy link
Copy Markdown
Member Author

Thank you as always @PipKat - really appreciated! Let me get your feedback in.

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@RobPasMue RobPasMue merged commit 7b41697 into main May 23, 2024
@RobPasMue RobPasMue deleted the feat/arc-ctors branch May 23, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arc using a point, a center and an angle Arc constructor based on 2 points and a radius

4 participants