fix: Rename built in shadowing variables#1257
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1257 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 85 85
Lines 6572 6572
=======================================
Hits 6051 6051
Misses 521 521 ☔ View full report in Codecov by Sentry. |
…sys-geometry into fix/builtin-shadowing
Contributor
Author
|
Everything seems to be working fine @RobPasMue , feel free to review 🙂 |
RobPasMue
requested changes
Jun 12, 2024
Member
RobPasMue
left a comment
There was a problem hiding this comment.
Other than my suggestion - LGTM
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
RobPasMue
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes shadowing caused by
visualization-interface. Fixed in ansys/ansys-tools-visualization-interface#75Checklist
feat: extrude circle to cylinder)