Skip to content

feat: adding deprecation support for args and methods#1261

Merged
RobPasMue merged 4 commits intomainfrom
feat/deprecation
Jun 17, 2024
Merged

feat: adding deprecation support for args and methods#1261
RobPasMue merged 4 commits intomainfrom
feat/deprecation

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue commented Jun 14, 2024

Description

Adding deprecation decorators for methods and arguments

Issue linked

Closes #1259

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jun 14, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner June 14, 2024 10:52
@github-actions github-actions bot added the enhancement New features or code improvements label Jun 14, 2024
@github-actions github-actions bot added the testing Anything related to tests label Jun 14, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.09%. Comparing base (9b67df7) to head (231f8ad).

Files Patch % Lines
src/ansys/geometry/core/designer/face.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
+ Coverage   92.07%   92.09%   +0.01%     
==========================================
  Files          85       85              
  Lines        6574     6613      +39     
==========================================
+ Hits         6053     6090      +37     
- Misses        521      523       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit a153ec6 into main Jun 17, 2024
@RobPasMue RobPasMue deleted the feat/deprecation branch June 17, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated APIs should still be available for a few releases

2 participants