Skip to content

build: adapting to numpy 2.x#1265

Merged
RobPasMue merged 2 commits intomainfrom
maint/numpy-2
Jun 18, 2024
Merged

build: adapting to numpy 2.x#1265
RobPasMue merged 2 commits intomainfrom
maint/numpy-2

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Adapting to the usage of Numpy 2.x

PR is blocked by visualization library dependencies (PyVista) not allowing Numpy 2.x on released versions (yet). Once that's fixed we can investigate the remaining deprecation warnings we may have

@RobPasMue RobPasMue requested a review from a team as a code owner June 17, 2024 11:36
@RobPasMue RobPasMue marked this pull request as draft June 17, 2024 11:36
@RobPasMue RobPasMue self-assigned this Jun 17, 2024
@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to tests labels Jun 17, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.09%. Comparing base (42d28ed) to head (f507abb).

Files Patch % Lines
src/ansys/geometry/core/shapes/surfaces/plane.py 0.00% 2 Missing ⚠️
src/ansys/geometry/core/shapes/curves/line.py 0.00% 1 Missing ⚠️
...rc/ansys/geometry/core/shapes/surfaces/cylinder.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1265   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files          85       85           
  Lines        6613     6613           
=======================================
  Hits         6090     6090           
  Misses        523      523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue marked this pull request as ready for review June 18, 2024 05:49
@RobPasMue RobPasMue merged commit a4ec588 into main Jun 18, 2024
@RobPasMue RobPasMue deleted the maint/numpy-2 branch June 18, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants