Skip to content

test: create sphere bug raised after box creation#1291

Merged
RobPasMue merged 8 commits intomainfrom
fix/create-sphere-issue-1184
Jul 11, 2024
Merged

test: create sphere bug raised after box creation#1291
RobPasMue merged 8 commits intomainfrom
fix/create-sphere-issue-1184

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue commented Jul 2, 2024

Description

Sphere creation after box creation fails

Issue linked

Closes #1184

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jul 2, 2024
@github-actions github-actions Bot added testing Anything related to tests bug Something isn't working labels Jul 2, 2024
@RobPasMue RobPasMue mentioned this pull request Jul 2, 2024
2 tasks
@RobPasMue RobPasMue marked this pull request as ready for review July 11, 2024 17:37
@RobPasMue RobPasMue requested a review from a team as a code owner July 11, 2024 17:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (ab1a597) to head (8dcc809).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1291   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          85       85           
  Lines        6598     6598           
=======================================
  Hits         6075     6075           
  Misses        523      523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 0121f52 into main Jul 11, 2024
@RobPasMue RobPasMue deleted the fix/create-sphere-issue-1184 branch July 11, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

design.create_sphere

3 participants