Skip to content

feat: name setter and fill style getter setters#1299

Merged
umutsoysalansys merged 18 commits into
mainfrom
feat/body_fill_style
Jul 18, 2024
Merged

feat: name setter and fill style getter setters#1299
umutsoysalansys merged 18 commits into
mainfrom
feat/body_fill_style

Conversation

@umutsoysalansys

@umutsoysalansys umutsoysalansys commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

Description

allowing setting name and fill style for bodies.
(example: notice cube name is updated from "matrix" to "m2" and set as transparent

image
image

Unit test is coming.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions Bot added the enhancement New features or code improvements label Jul 10, 2024
@umutsoysalansys umutsoysalansys changed the title name setter and fill style getter setters feat: name setter and fill style getter setters Jul 10, 2024
@umutsoysalansys umutsoysalansys self-assigned this Jul 10, 2024
@umutsoysalansys umutsoysalansys requested a review from smereu July 10, 2024 21:15
@RobPasMue

Copy link
Copy Markdown
Member

@umutsoysalansys did you manage to investigate the issues with the Docker image?

@codecov

codecov Bot commented Jul 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.03%. Comparing base (c6ae5c1) to head (313273d).

Files Patch % Lines
src/ansys/geometry/core/designer/body.py 94.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
+ Coverage   92.01%   92.03%   +0.01%     
==========================================
  Files          86       86              
  Lines        6660     6713      +53     
==========================================
+ Hits         6128     6178      +50     
- Misses        532      535       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue

Copy link
Copy Markdown
Member

Oh well - everything is solved now. Please implement some testing for this feature

@umutsoysalansys umutsoysalansys marked this pull request as ready for review July 16, 2024 17:43
@umutsoysalansys umutsoysalansys requested a review from a team as a code owner July 16, 2024 17:43
Comment thread src/ansys/geometry/core/designer/body.py Outdated
umutsoysalansys and others added 2 commits July 16, 2024 16:46
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Comment thread src/ansys/geometry/core/designer/body.py
Comment thread src/ansys/geometry/core/designer/body.py Outdated
Comment thread src/ansys/geometry/core/designer/body.py
Comment thread tests/integration/test_design.py Outdated
@umutsoysalansys

Copy link
Copy Markdown
Contributor Author

@RobPasMue anything else on this one?

@RobPasMue

Copy link
Copy Markdown
Member

Yes, let me check out your branch so that you understand what I meant =)

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work here @umutsoysalansys. I just pushed to "stable" the latest unstable Docker image since the tests were passing. We are good to go now :)

@umutsoysalansys

umutsoysalansys commented Jul 18, 2024 via email

Copy link
Copy Markdown
Contributor Author

Comment thread src/ansys/geometry/core/designer/body.py Outdated
@umutsoysalansys umutsoysalansys merged commit 6af4805 into main Jul 18, 2024
@umutsoysalansys umutsoysalansys deleted the feat/body_fill_style branch July 18, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants