feat: name setter and fill style getter setters#1299
Merged
Conversation
Member
|
@umutsoysalansys did you manage to investigate the issues with the Docker image? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
==========================================
+ Coverage 92.01% 92.03% +0.01%
==========================================
Files 86 86
Lines 6660 6713 +53
==========================================
+ Hits 6128 6178 +50
- Misses 532 535 +3 ☔ View full report in Codecov by Sentry. |
Member
|
Oh well - everything is solved now. Please implement some testing for this feature |
MaxJPRey
reviewed
Jul 16, 2024
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
RobPasMue
requested changes
Jul 17, 2024
Contributor
Author
|
@RobPasMue anything else on this one? |
Member
|
Yes, let me check out your branch so that you understand what I meant =) |
RobPasMue
approved these changes
Jul 18, 2024
RobPasMue
left a comment
Member
There was a problem hiding this comment.
LGTM! Great work here @umutsoysalansys. I just pushed to "stable" the latest unstable Docker image since the tests were passing. We are good to go now :)
Contributor
Author
|
[like] Umut Soysal reacted to your message:
…________________________________
From: Roberto Pastor Muela ***@***.***>
Sent: Thursday, July 18, 2024 7:18:16 AM
To: ansys/pyansys-geometry ***@***.***>
Cc: Umut Soysal ***@***.***>; Mention ***@***.***>
Subject: Re: [ansys/pyansys-geometry] feat: name setter and fill style getter setters (PR #1299)
[External Sender]
@RobPasMue approved this pull request.
LGTM! Great work here @umutsoysalansys<https://github.com/umutsoysalansys>. I just pushed to "stable" the latest unstable Docker image since the tests were passing. We are good to go now :)
—
Reply to this email directly, view it on GitHub<#1299 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXFRLEUJMFUFEEQGYYWL2T3ZM5T3RAVCNFSM6AAAAABKVVI2W6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBUHEZDINBTHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
umutsoysalansys
commented
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
allowing setting name and fill style for bodies.
(example: notice cube name is updated from "matrix" to "m2" and set as transparent
Unit test is coming.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)