feat: extract fluid volume from solid#1306
Conversation
Expose APIs for volume extraction from sealing faces or sealing edge loops
More files for volume extraction exposure
Fix code style from precommit check
Add geometry update if bodies created
…sys/pyansys-geometry into feat/smereu/volume_extraction
RobPasMue
left a comment
There was a problem hiding this comment.
Some minor suggestions. Overall, LGTM!
|
There are problems with the unstable image and the stable image does not include these features so.. until that is solved we won't be able to merge the PR |
code review Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Respond to code review
|
@RobPasMue A few comments, in case they could help someone with similar questions
|
|
Hi @smereu - point taken! :) @reset_cache is not needed on your PR. @ensure_design_is_active might be interesting. Let me check in depth your PR. Also, I left some additional comments which I think weren't addressed, I'll do the modifications myself. :) Nonetheless, the PR won't be able to be merged yet. There seems to be some issues in the implementation. Looking into them as well |
…sys/pyansys-geometry into feat/smereu/volume_extraction
|
Thanks Roberto and apologies for giving you more work :-(. ensure_design_is_active should not be needed here because we are inferring the design from the geometry. I was not clear why it is needed in some other methods where I saw it but that is a topic for discussion separate from this PR. |
…sys/pyansys-geometry into feat/smereu/volume_extraction
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
- Coverage 92.07% 92.01% -0.07%
==========================================
Files 85 86 +1
Lines 6602 6660 +58
==========================================
+ Hits 6079 6128 +49
- Misses 523 532 +9 ☔ View full report in Codecov by Sentry. |
Description
This PR provides the functionality to extract a flow volume from a list of sealing faces or edge loops
Issue linked
#1305
Checklist
feat: extrude circle to cylinder)