Skip to content

fix: default length units not being used properly on arc creation#1310

Merged
RobPasMue merged 3 commits into
mainfrom
fix/default-units-on-sketch-arc-creation
Jul 16, 2024
Merged

fix: default length units not being used properly on arc creation#1310
RobPasMue merged 3 commits into
mainfrom
fix/default-units-on-sketch-arc-creation

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

Problem related to the way default units are consumed inside the arc creation based on points.

Issue linked

Closes #1304

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jul 16, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner July 16, 2024 07:40
@github-actions github-actions Bot added the bug Something isn't working label Jul 16, 2024
@RobPasMue RobPasMue enabled auto-merge (squash) July 16, 2024 07:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (0535c1f) to head (18f1fe4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1310   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          85       85           
  Lines        6598     6600    +2     
=======================================
+ Hits         6075     6077    +2     
  Misses        523      523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 7847aea into main Jul 16, 2024
@RobPasMue RobPasMue deleted the fix/default-units-on-sketch-arc-creation branch July 16, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in arc_from_start_end_and_radius

3 participants